feat: replace option-like arrays via conditionals#263
Merged
Conversation
0e60932 to
2272b96
Compare
Collaborator
Author
|
Internal pipeline is 🟢 |
sandrina-p
reviewed
Jul 6, 2026
danielcardoso5
commented
Jul 6, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d8dedad. Configure here.
d8dedad to
f06bb2a
Compare
sandrina-p
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Matches v0 behavior by allowing to override option-like arrays present in
oneOf/anyOfproperties. This allows to change the list of options allowed for fields based on conditionals.Example:
Schema
{ "type": "object", "additionalProperties": false, "properties": { "trigger": { "type": "string" }, "choice": { "type": "string", "oneOf": [ { "const": "a", "title": "A" }, { "const": "b", "title": "B" }, { "const": "c", "title": "C" } ] } }, "allOf": [ { "if": { "properties": { "trigger": { "const": "only c" } }, "required": [ "trigger" ] }, "then": { "properties": { "choice": { "oneOf": [ { "const": "c", "title": "C" } ] } } } } ] }Note
Medium Risk
Changes core schema merge logic used when applying conditionals and updating fields; wrong array handling could break validation or option lists across many forms.
Overview
deepMergeSchemasnow fully replaces schema arrays when a conditional branch supplies new values—exceptrequired, which still only appends missing entries. That replaces the old behavior that special-casedoptionsand tried to merge array contents (including a buggy recursive merge on object items).Conditional
allOf/if/thenmerges can therefore narrow or swap field choices:oneOf,anyOf,enum, and presentationoptionsupdate on validation and revert when the branch is inactive, with validation aligned to the active set.Tests cover
deepMergeSchemasedge cases,convertKBToMB, and headless-form scenarios for conditionaloneOf,anyOf, andenum.Reviewed by Cursor Bugbot for commit f06bb2a. Bugbot is set up for automated code reviews on this repo. Configure here.