You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code Review: Fix depositories addresses not showing up
Read the diff and full snippet
Review for correctness and style
This correctly fixes the empty Chain column: the /chains API returns displayName (not name), so switching ${chain.name} → ${chain.displayName} on line 34 is the right fix. Moving VM_TYPE_LABELS into appendDepositories is harmless. Two things to clean up before merge:
🔴 Blocking — leftover debugger; statement
snippets/Depositories.mdx:48
constfetchChains=async()=>{debugger;// ← remove this
This is a debugging artifact. In production it will pause execution for any visitor who has browser devtools open, and it shouldn't ship in a docs snippet.
The moved const VM_TYPE_LABELS = { line has 7 leading spaces instead of 6, so it's misaligned with the surrounding block. Cosmetic, but worth tidying while you're in here.
Note (pre-existing, not introduced by this PR)
The loader element on line 97 is given a className (loader-container-${id}), but lines 41 and 66 look it up via document.getElementById(...). getElementById matches on id, not class, so the loader-hiding logic never finds that element. Out of scope for this fix, but flagging since you're touching this file.
Overall the fix itself is correct — just drop the debugger; and this is good to go.
💡 Tip: Enable Workflows to automatically generate PRs for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.