Goals PR2 companion — relationship-scoped goals with per-session display by jhodapp · Pull Request #330 · refactor-group/refactor-platform-fe

jhodapp · 2026-03-10T00:27:47Z

Description

Frontend companion for backend PR2 (goals relationship scoping). Updates the Goal type, API layer, and UI components to work with the new relationship-scoped goals and coaching_sessions_goals join table.

Coordinated deploy: must merge alongside backend PR #242.

Changes

Update Goal interface: remove coaching_session_id, add coaching_relationship_id (required), created_in_session_id (nullable), target_date (nullable)
Update GoalApi.list() to send coaching_relationship_id query param
Add GoalApi.listBySession() and useGoalsBySession hook for GET /coaching_sessions/{id}/goals (join table endpoint)
Fix per-session goal display in dashboard session cards and coaching session goal drawer
Send created_in_session_id on goal creation to trigger backend auto-link
Apply render guard pattern in GoalContainer
Add 38 new tests: Goal type (27), GoalApi/hooks (11)

Screenshots / Videos Showing UI Changes (if applicable)

None

Testing Strategy

663 tests passing (38 new)
Manual verification: dashboard shows correct per-session goals, goal drawer shows session-specific goal, creating a goal from session context auto-links it

Concerns

include=goal on enriched sessions endpoint still works for existing data but will become incomplete as new join table links are created — migration to join table endpoint is done in this PR

…n display Update Goal type from session-scoped (coaching_session_id) to relationship-scoped (coaching_relationship_id, created_in_session_id nullable, target_date nullable). Use GET /coaching_sessions/{id}/goals join table endpoint for per-session goal display in dashboard cards and coaching session goal drawer. Send created_in_session_id on goal creation to trigger backend auto-link.

Goal SSE events (created/updated/deleted) now also invalidate /coaching_sessions SWR keys, covering the GET /coaching_sessions/{id}/goals join table endpoint used for per-session goal display.

Extract DEFAULT_GOAL_TITLE constant and goalTitle() helper in goal.ts to consistently handle empty/null goal titles across 6 UI call sites.

…sion - Add missing field checks (title, body, target_date, status_changed_at, completed_at) to isGoal type guard to prevent malformed data at boundary - Conditionally construct URL in useGoalsBySession to avoid embedding "null" string when session ID is absent - Remove as-any casts in goal API tests, remove test that asserted null-in-URL implementation detail

invalidateEndpoint('/coaching_sessions') was too broad — it revalidated every SWR key containing that path, causing the coaching session title to flash on goal updates. Replace with a targeted invalidator that only matches /coaching_sessions/{id}/goals keys.

…apes

calebbourg

Just a couple of thoughts. Not sure if they're valid

calebbourg · 2026-03-10T21:41:24Z

-          // any other local code using the KeyedMutator will also update with this new data.
-          refresh();
-        }
+      if (goal.id) {


Is goal here the goal that's defined on line 30? If so would it make sense to pass it in as an argument here? I've seen referencing variables from outside of the function scope in JS before but not sure what the best practice is.

Great catch. Fixed in 49e71a9.

calebbourg · 2026-03-10T21:43:08Z

+   * @param coachingSessionId The ID of the coaching session
+   * @returns Promise resolving to an array of Goal objects linked to the session
+   */
+  listBySession: async (coachingSessionId: Id): Promise<Goal[]> => {


I think it would be more conventional to this app for this to be called listNested similar to createNested

Fixed in 49e71a9.

Address PR review feedback: use listNested convention with EntityApi.listNestedFn and make handleGoalChange accept the current goal explicitly instead of closing over component scope.

Surface a destructive toast when the backend returns HTTP 409 because the coaching relationship already has 3 active goals. Adds ActiveGoalLimitError types and extractActiveGoalLimitError helper for reuse in future swap dialog work.

"Active" means InProgress only — NotStarted does not count. Use max_active_goals from 409 response instead of hardcoding. Rename ACTIVE_GOAL_LIMIT to DEFAULT_MAX_ACTIVE_GOALS. Return ActiveGoalLimitInfo (with limit + goals) from the extractor.

Mark backend PR1/PR2 as merged with links to PRs (#242, #330). Update API gap analysis with PR2 completion status. Correct active goal limit from frontend-only to backend-enforced (409 Conflict). Update join table endpoints to nested routes. Add Layer 2 PR2 companion deliverables and remaining work blockers. Document auto-link on creation interim behavior.

github-actions · 2026-03-13T16:48:49Z

🚀 PR Preview Environment Deployed!

🔗 Access URLs

Service	URL
Frontend	http://neo/pr-330/
Backend API	http://neo/pr-330/api
Health Check	http://neo/pr-330/health
Base Path	`/pr-330/`

📊 Environment Details

PR Number: Goals PR2 companion — relationship-scoped goals with per-session display #330
Repository Type: frontend
Backend Branch: main → ghcr.io/refactor-group/refactor-platform-rs:main-arm64
Frontend Branch: feat/goals-pr2-companion → ghcr.io/refactor-group/refactor-platform-fe:pr-330
Commit: 9e1887f71befdbf0b9004cdd9242a519c489cd6c
Access Method: NGINX path-based routing (no direct port access)
Build Type: 🚀 Native ARM64

🧪 Testing

# Health check
curl http://neo/pr-330/health

# Frontend
curl http://neo/pr-330/

# API test
curl http://neo/pr-330/api/v1/users

🧹 Cleanup

Environment auto-cleaned when PR closes/merges

Deployed: 2026-03-13T16:48:47.808Z
Architecture: Native ARM64 build on Neo + Multi-tier caching

Mark backend PR1/PR2 as merged with links to PRs (#242, #330). Update API gap analysis with PR2 completion status. Correct active goal limit from frontend-only to backend-enforced (409 Conflict). Update join table endpoints to nested routes. Add Layer 2 PR2 companion deliverables and remaining work blockers. Document auto-link on creation interim behavior.

jhodapp temporarily deployed to pr-preview March 10, 2026 00:27 — with GitHub Actions Inactive

jhodapp changed the title ~~feat: goals PR2 companion — relationship-scoped goals with per-session display~~ Goals PR2 companion — relationship-scoped goals with per-session display Mar 10, 2026

jhodapp self-assigned this Mar 10, 2026

jhodapp added the enhancement Improves existing functionality or feature label Mar 10, 2026

jhodapp added this to Refactor Coaching Platform Mar 10, 2026

jhodapp moved this to 🏗 In progress in Refactor Coaching Platform Mar 10, 2026

jhodapp added this to the 1.0.0-beta3 milestone Mar 10, 2026

jhodapp temporarily deployed to pr-preview March 10, 2026 00:32 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 00:38 — with GitHub Actions Inactive

fix: invalidate session-scoped goal caches on goal SSE events

b74b2d0

Goal SSE events (created/updated/deleted) now also invalidate /coaching_sessions SWR keys, covering the GET /coaching_sessions/{id}/goals join table endpoint used for per-session goal display.

jhodapp temporarily deployed to pr-preview March 10, 2026 00:38 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 00:42 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 00:47 — with GitHub Actions Inactive

refactor: standardize goal title display with goalTitle helper

092e0d0

Extract DEFAULT_GOAL_TITLE constant and goalTitle() helper in goal.ts to consistently handle empty/null goal titles across 6 UI call sites.

jhodapp temporarily deployed to pr-preview March 10, 2026 00:57 — with GitHub Actions Inactive

jhodapp had a problem deploying to pr-preview March 10, 2026 00:57 — with GitHub Actions Failure

jhodapp marked this pull request as ready for review March 10, 2026 00:58

jhodapp moved this from 🏗 In progress to Review in Refactor Coaching Platform Mar 10, 2026

jhodapp had a problem deploying to pr-preview March 10, 2026 15:43 — with GitHub Actions Failure

jhodapp temporarily deployed to pr-preview March 10, 2026 15:43 — with GitHub Actions Inactive

jhodapp had a problem deploying to pr-preview March 10, 2026 16:04 — with GitHub Actions Failure

jhodapp temporarily deployed to pr-preview March 10, 2026 16:04 — with GitHub Actions Inactive

fix: widen goalTitle param to Pick<Goal, "title"> for partial goal sh…

600f309

…apes

jhodapp temporarily deployed to pr-preview March 10, 2026 16:15 — with GitHub Actions Inactive

jhodapp requested a review from calebbourg March 10, 2026 16:18

jhodapp temporarily deployed to pr-preview March 10, 2026 16:20 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 16:24 — with GitHub Actions Inactive

calebbourg requested changes Mar 10, 2026

View reviewed changes

refactor: rename listBySession to listNested, pass goal as parameter

49e71a9

Address PR review feedback: use listNested convention with EntityApi.listNestedFn and make handleGoalChange accept the current goal explicitly instead of closing over component scope.

jhodapp temporarily deployed to pr-preview March 10, 2026 22:55 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 22:59 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 10, 2026 23:03 — with GitHub Actions Inactive

jhodapp added 2 commits March 11, 2026 15:47

jhodapp temporarily deployed to pr-preview March 11, 2026 21:00 — with GitHub Actions Inactive

jhodapp had a problem deploying to pr-preview March 11, 2026 21:05 — with GitHub Actions Failure

jhodapp temporarily deployed to pr-preview March 11, 2026 21:15 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 11, 2026 21:17 — with GitHub Actions Inactive

calebbourg approved these changes Mar 11, 2026

View reviewed changes

jhodapp mentioned this pull request Mar 12, 2026

Scope goals to coaching relationships with many-to-many session linking refactor-group/refactor-platform-rs#242

Merged

Merge branch 'main' into feat/goals-pr2-companion

bbf3f60

jhodapp temporarily deployed to pr-preview March 13, 2026 16:35 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 13, 2026 16:39 — with GitHub Actions Inactive

jhodapp temporarily deployed to pr-preview March 13, 2026 16:47 — with GitHub Actions Inactive

jhodapp merged commit 9ae55f0 into main Mar 13, 2026
12 checks passed

github-project-automation Bot moved this from Review to ✅ Done in Refactor Coaching Platform Mar 13, 2026

jhodapp deleted the feat/goals-pr2-companion branch March 13, 2026 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Goals PR2 companion — relationship-scoped goals with per-session display#330

Goals PR2 companion — relationship-scoped goals with per-session display#330
jhodapp merged 10 commits into
mainfrom
feat/goals-pr2-companion

jhodapp commented Mar 10, 2026

Uh oh!

calebbourg left a comment

Uh oh!

calebbourg Mar 10, 2026

Uh oh!

jhodapp Mar 10, 2026

Uh oh!

calebbourg Mar 10, 2026

Uh oh!

jhodapp Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jhodapp commented Mar 10, 2026

Description

Changes

Screenshots / Videos Showing UI Changes (if applicable)

Testing Strategy

Concerns

Uh oh!

calebbourg left a comment

Choose a reason for hiding this comment

Uh oh!

calebbourg Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

jhodapp Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

calebbourg Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

jhodapp Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 13, 2026

🚀 PR Preview Environment Deployed!

🔗 Access URLs

📊 Environment Details

🧪 Testing

🧹 Cleanup

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants