feat(terrain): add Water Mask toggle to terrain settings - #2373
Open
ZTongci wants to merge 4 commits into
Open
Conversation
Adds a Water Mask on/off switch in the Editor terrain settings panel, directly below the terrain enable toggle. Defaults to true (preserves current behavior). Requires @reearth/core with waterMask support. - manifest.yml / manifest_ja.yml: new terrainWaterMask bool field in both terrain schema groups, with availableIf: terrain=true on the main group - sceneProperty.ts: terrainWaterMask?: boolean in TerrainProperty - convert-object.ts: terrain.terrainWaterMask → terrain.waterMask Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
ZTongci
requested review from
airslice,
mkumbobeaty and
wilfredmulenga
as code owners
August 7, 2026 02:34
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Water Mask boolean scene property to terrain settings and wires it through the web viewer-property conversion so it can be consumed by @reearth/core.
Changes:
- Adds
terrainWaterMaskas a boolean field in the built-in terrain property schemas (EN/JA manifests). - Extends the frontend SceneProperty typing with
terrainWaterMask?: boolean. - Maps
terrain.terrainWaterMask→terrain.waterMaskin the scene→viewer property conversion mapping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/pkg/builtin/manifest.yml | Adds the terrainWaterMask field to terrain schema groups (cesium-beta + cesium). |
| server/pkg/builtin/manifest_ja.yml | Adds Japanese title/description entries for terrainWaterMask. |
| web/src/app/types/sceneProperty.ts | Adds terrainWaterMask?: boolean to TerrainProperty. |
| web/src/app/utils/convert-object.ts | Maps backend scene property terrainWaterMask to viewer property terrain.waterMask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Cloud Run Preview Deployed |
Matches the core-side default change: off by default so existing projects are not visually affected on upgrade. Users enable it explicitly. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…hema The cesium-beta schema group already had availableIf: terrain=true on terrainWaterMask, but the legacy cesium schema group was missing it. This caused the Water Mask toggle to appear even when terrain is disabled. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Core dependency
reearth/core#164 — `feat(terrain): add configurable waterMask prop`
Published as `@reearth/[email protected]`.
2026-08-07.20.36.47.mov