Scope Cloud Topics shadow link limitation to versions earlier than 26.2 - #1812
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdates the Cloud Topics limitations note to clarify that shadow links did not support Cloud Topics before Redpanda 26.2, and that this limitation is lifted starting with version 26.2. Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Shadow links support Cloud Topics starting in Redpanda 26.2, so the limitation now applies only to earlier versions. Co-Authored-By: Claude Fable 5 <[email protected]>
ce7c628 to
2c93a0e
Compare
The version scoping already implies the limitation is lifted in v26.2, so drop the redundant second sentence. Co-Authored-By: Claude Fable 5 <[email protected]>
Includes the merge of current beta (the What's New page was reset for 26.2 after this branch was cut). Co-Authored-By: Claude Fable 5 <[email protected]>
|
@copilot resolve the merge conflicts in this pull request |
…ink-26.2 # Conflicts: # modules/develop/partials/cloud-topics-limitations.adoc # modules/get-started/pages/release-notes/redpanda.adoc
Merge conflicts resolved in commit
|
Feediver1
left a comment
Feediver1
left a comment
There was a problem hiding this comment.
PR Review (docs-team-standards final pass)
Files reviewed: 2 (the Cloud Topics limitations partial + the What's New entry, the latter added by the docs team for DOC-2395)
Overall assessment: The core change is correct, minimal, and merge-clean. Two open items are docs-team decisions rather than author changes; nothing blocks on the author's side.
Jira ticket alignment
DOC-2127 (Cloud Topics: support Shadowing): this PR delivers the limitation-scoping half. Scope caution on "fulfills": the positive half may still be owed — the 25.3 shadowing model explicitly excluded redpanda.cloud_topic.enabled from replicated topic properties, so if shadow links now support Cloud Topics, the Configure Shadowing page's property-sync story may need a corresponding update (do Cloud Topics shadow as Cloud Topics? does that property now sync?). Recommend keeping DOC-2127 open for that verification rather than closing it on this merge.
Verified
- The branch already carries beta's post-#1813 conversion-line text in the same partial — the cross-PR collision that would otherwise be this review's headline was pre-avoided.
- A three-way merge simulation against current
betais conflict-free. - The version-scoped wording follows the repo convention (matching #1813's treatment of the adjacent line) and renders correctly in both consumers of the single-sourced partial (Self-Managed Cloud Topics page + K8s index, and the cloud build).
Open items (docs-team decisions)
- The earlier review suggestion was resolved without application or reply ("Starting in v26.2, this limitation no longer applies."). On the merits the current one-sentence form already implies it, so declining is defensible — but the resolution should be explicit, not silent. Reviewer to re-apply or bless.
- Merge order vs #1828: both PRs rewrite the What's New entries region, so whichever merges second hits a trivial conflict. Cleanest: merge this PR first, then slot "Shadowing support for Cloud Topics" into #1828's specified order during its conflict resolution (natural home: after "Shadowing: role synchronization").
What works well
- Minimal, convention-following change with correct single-source awareness — exactly the right size for the ask.
🤖 Generated with Claude Code
Description
Shadow links support Cloud Topics starting in Redpanda v26.2. This updates the Cloud Topics limitations partial so the "shadow links do not support Cloud Topics" limitation is scoped to versions earlier than 26.2, following the repo's existing version-scoped wording convention.
Fulfills request in https://redpandadata.atlassian.net/browse/DOC-2127
Review deadline:
Page previews
https://deploy-preview-1812--redpanda-docs-preview.netlify.app/streaming/26.2/develop/manage-topics/cloud-topics/
https://deploy-preview-1812--redpanda-docs-preview.netlify.app/streaming/26.2/manage/kubernetes/cloud-topics/
Checks
🤖 Generated with Claude Code
Preview pages