[RHIDP#RHDHBUGS-3359]: Add missing Common icons reference section (release-1.10) - #2507
Open
rh-tokeefe wants to merge 7 commits into
Open
[RHIDP#RHDHBUGS-3359]: Add missing Common icons reference section (release-1.10)#2507rh-tokeefe wants to merge 7 commits into
rh-tokeefe wants to merge 7 commits into
Conversation
Collaborator
PR Build ResultsBuild passed -- 35/35 titles | 76s Content Quality AssessmentCQA Report
SummaryChecks: 19 total, 19 pass, 0 fail 19 checks: 19 pass, 0 fail Run Updated 2026-08-05 17:02:12 UTC |
rh-tokeefe
force-pushed
the
RHDHBUGS-3359B
branch
from
July 30, 2026 18:54
172785f to
c55c1f9
Compare
Created ref-common-icons-for-customization.adoc to document the predefined system icon identifiers available in RHDH. This fixes broken cross-references in three procedure files that were linking to a non-existent #ref-common-icons anchor. The new reference module: - Lists commonly used icon identifiers (add, catalog, github, etc.) - Explains alternative icon types (URLs, SVG paths, relative paths) - Links to extend-internal-icon-catalog for custom icons - Provides link to upstream Backstage icon set Also updated assembly-configure-the-global-header-in-rhdh.adoc to include the new reference module. Fixes broken links in: - proc-configure-the-logo-in-the-global-header.adoc - proc-customize-your-rhdh-quick-start.adoc - proc-use-hosted-json-files-to-provide-data-to-the-quick-access-card.adoc Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Updated xref to extend-internal-icon-catalog to use the actual
context value 'front-end-plugin-wiring' instead of the {context}
variable, following documentation best practices.
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Removed the link to the upstream Backstage GitHub repository to comply with product documentation guidelines that avoid linking to external GitHub repositories. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
…onsolidate icon tables - Add Backstage system icons table (kind:* entity icons and general UI icons) - Add data-encoded URIs to supported icon formats - Replace duplicate icon type table in QuickAccessCard module with xref to common icons reference - Remove bare GitHub link from QuickAccessCard icon table Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
rh-tokeefe
force-pushed
the
RHDHBUGS-3359B
branch
from
August 4, 2026 20:51
c55c1f9 to
4f2e490
Compare
Replace intra-title xref with cross-title product-docs-link for the extend-internal-icon-catalog reference, which lives in the installing-and-viewing-plugins title, not configure_customizing-rhdh. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The quickaccesscard module lives in the customize-the-home-page assembly
but xrefs the common-icons module in configure-the-global-header-in-rhdh.
Using {context} resolves to the wrong assembly context. Hardcode the
correct target context.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s): 1.10
Issue: RHDHBUGS-3359
Preview: N/A
Summary
Cherry-pick of PR #2382 (release-1.9) to release-1.10, plus scorecard-specific additions:
🤖 Generated with Claude Code