refactor(modelsasservice): [3.5-ea.2] move NetworkPolicy to upstream manifests - #34511
Open
ugiordan wants to merge 1 commit into
Open
refactor(modelsasservice): [3.5-ea.2] move NetworkPolicy to upstream manifests#34511ugiordan wants to merge 1 commit into
ugiordan wants to merge 1 commit into
Conversation
Move the payload-processing NetworkPolicy from operator Go code (#3699) to the upstream models-as-a-service kustomize bundle (opendatahub-io/models-as-a-service#1084), where it belongs alongside the other payload-processing resources. Operator-side changes: - Remove payloadProcessingNetworkPolicy() raw map[string]any builder - Add NetworkPolicy to gatewayNamespaceResources so the existing kustomize pipeline handles namespace restoration - The NP now flows through the same rendering pipeline as all other payload-processing resources (Deployment, Service, ServiceAccount) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Author
|
/hold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of opendatahub-io/opendatahub-operator#3747 for rhoai-3.5-ea.2.
Moves the payload-processing NetworkPolicy from Go-constructed code to the upstream models-as-a-service kustomize bundle.
What changed
payloadProcessingNetworkPolicy()Go builder functionrestoreGatewayNamespaceResources, label injection, GC cleanup)gatewayNamespaceResourcesalready includes the NP entry for namespace restorationWhy
The payload-processing Deployment, Service, ServiceAccount, and ConfigMap already come from the upstream kustomize bundle. The NP was the only resource the operator was constructing in Go.
Related PRs