Skip to content

feat(releases): show status-resolution on Test Execution Phases - #1436

Open
ppitonak wants to merge 1 commit into
mainfrom
feat/rhoaieng-82493-test-execution-resolution
Open

feat(releases): show status-resolution on Test Execution Phases#1436
ppitonak wants to merge 1 commit into
mainfrom
feat/rhoaieng-82493-test-execution-resolution

Conversation

@ppitonak

Copy link
Copy Markdown
Contributor

Display Epic and task Resolution alongside Status (rendered as "Status - Resolution") in the release readiness dashboard's Test Execution Phases section, with muted color coding for no-work resolutions (Won't Do, Can't Do, Obsolete, Duplicate, Cannot Reproduce) so completed-but-not-done work is visually distinct from real completions.

RHOAIENG-82493

Screenshot_20260818_112047

@ppitonak
ppitonak requested a review from aloganat August 18, 2026 10:00
@ppitonak
ppitonak requested a review from saprabhu05 as a code owner August 18, 2026 10:00
@claude

claude Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ppitonak's task in 2m 4s —— View job


PR Review: feat(releases): show status-resolution on Test Execution Phases

  • Gather context and read review instructions
  • Read changed files and review diff
  • Check for issues (bugs, style, conventions, hard constraints)
  • Fix any issues found
  • Post review findings and verdict

Review Summary

Verdict: PASS — Clean, well-scoped PR. No blocking issues found.

What the PR does

Adds Jira resolution display alongside status in the Test Execution Phases section of the release readiness dashboard. No-work resolutions (Won't Do, Can't Do, Obsolete, Duplicate, Cannot Reproduce) get muted gray styling with strikethrough so they're visually distinct from real completions. Falls back gracefully to existing RAG-based labels when status/resolution fields are absent (older payloads).

What I checked

Area Result
Hard constraints All clear — no cross-module imports, no TypeScript, no process.env, storage abstractions not relevant (client-only change), docs updated in same PR
Security No user input handling, no API changes — N/A
Correctness Backward-compatible signature change, graceful fallbacks for missing fields
Code quality Clean helper functions, good separation of concerns
API documentation No new routes — N/A
Documentation sync docs/DATA-FORMATS.md and fixtures/ both updated (hard constraint 8)

Notes

  • statusPillClass signature change is backward-compatible: The function changed from (category)(category, resolution). Two existing callers in the Component Readiness Matrix section (lines 313, 322) still pass only category. This works correctly because isNoWorkResolution(undefined) short-circuits to false via !!resolution.

  • No issues found, no fixes applied.

  • I was unable to run lint/tests locally due to tool permission restrictions, but CI checks are passing (Integration Tests ✅, Guard AI Configurations ✅). The main CI run is still in progress.


@ppitonak
ppitonak force-pushed the feat/rhoaieng-82493-test-execution-resolution branch from cb83d37 to 8b90b43 Compare August 18, 2026 10:36
@claude

claude Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ppitonak's task in 1m 55s —— View job


PR Review: feat(releases): show status-resolution on Test Execution Phases

  • Checkout PR branch and gather context
  • Read review instructions and hard constraints
  • Read changed files and review diff
  • Check for issues (bugs, style, conventions, hard constraints)
  • Fix any issues found — none needed
  • Post review findings and verdict

Verdict: PASS — Clean, well-scoped PR. No blocking issues found.

What the PR does

Adds Jira resolution display alongside status in the Test Execution Phases section of the release readiness dashboard. No-work resolutions (Won't Do, Can't Do, Obsolete, Duplicate, Cannot Reproduce) get muted gray styling with strikethrough so they're visually distinct from real completions. Falls back gracefully to RAG-based labels when status/resolution fields are absent (older payloads).

What I checked

Area Result
Hard constraints All clear — no cross-module imports, no TypeScript, no process.env, storage abstractions N/A (client-only), docs + fixtures updated in same PR
Security N/A — no user input handling, no API changes
Correctness Backward-compatible signature change, graceful fallbacks for missing fields
Code quality Clean helper functions, good separation of concerns
API documentation N/A — no new routes
Performance No concerns — simple string comparisons
Integration tests Existing release readiness tests verify the report loads without errors, which covers runtime breakage from this change

Notes

  • statusPillClass signature change is backward-compatible: Changed from (category)(category, resolution). Two existing callers in the Component Readiness Matrix section (lines 313, 322) still pass only category. This works correctly because isNoWorkResolution(undefined) short-circuits to false via !!resolution.

  • Fixture is well-structured: New RC2 phase with "Won't Do" and "Obsolete" resolutions provides good demo coverage of the muted styling. The test_timeline and breakdowns.phases[].tasks entries are consistent.

  • No issues found, no fixes applied.


CI: Integration Tests ✅ | Guard AI Configurations ✅ | CI (main) still in progress

Display Epic and task Resolution alongside Status (rendered as
"Status - Resolution") in the release readiness dashboard's Test
Execution Phases section, with muted color coding for no-work
resolutions (Won't Do, Can't Do, Obsolete, Duplicate, Cannot
Reproduce) so completed-but-not-done work is visually distinct
from real completions.

RHOAIENG-82493

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Signed-off-by: Pavol Pitonak <[email protected]>
@ppitonak
ppitonak force-pushed the feat/rhoaieng-82493-test-execution-resolution branch 2 times, most recently from 8b90b43 to bbd3981 Compare August 18, 2026 12:41
@claude

claude Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ppitonak's task in 1m 54s —— View job


PR Review: feat(releases): show status-resolution on Test Execution Phases

  • Checkout PR branch and gather context
  • Read review instructions and hard constraints
  • Read changed files and review diff
  • Check for issues (bugs, style, conventions, hard constraints)
  • Fix any issues found — none needed
  • Post review findings and verdict

Verdict: PASS — Clean, well-scoped PR. No blocking issues found.

What the PR does

Adds Jira resolution alongside status in the Test Execution Phases section (rendered as Status - Resolution). No-work resolutions (Won't Do, Can't Do, Obsolete, Duplicate, Cannot Reproduce) get muted gray styling so they're visually distinct from real completions. Falls back gracefully to just status when resolution is absent (older payloads).

What I checked

Area Result
Hard constraints All clear — no cross-module imports, no TypeScript, no process.env, storage abstractions N/A (client-only), docs + fixtures updated in same PR (HC 8)
Security N/A — no user input handling, no API changes
Correctness Backward-compatible signature change, graceful fallbacks for missing fields
Code quality Clean helper functions, good separation of concerns
API documentation N/A — no new routes
Performance No concerns — simple string comparisons
Screenshot Verified muted gray styling on no-work resolutions, green styling on real completions, status-only fallback for unresolved tasks

Notes

  • statusPillClass signature change is backward-compatible: Changed from (category)(category, resolution). Two existing callers in the Component Readiness Matrix section (lines 313, 322) still pass only category. This works correctly because isNoWorkResolution(undefined) short-circuits to false via !!resolution.

  • Badge width fix: The w-16 text-center addition (line 416) standardizes badge width in the phase accordion headers — good UX touch to prevent layout shifts.

  • Fixture coverage is solid: RC2 phase with "Won't Do" and "Obsolete" resolutions, plus "resolution": null on unresolved items, covers all code paths.

  • No issues found, no fixes applied.


CI: Integration Tests ✅ | Guard AI Configurations ✅ | CI in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant