Decouple versions file from PCC catalog commits (main) - #29531
Open
crackcodecamp wants to merge 1 commit into
Open
Decouple versions file from PCC catalog commits (main)#29531crackcodecamp wants to merge 1 commit into
crackcodecamp wants to merge 1 commit into
Conversation
When operator indexes update partially (some OCP versions get the new bundle, others don't yet), the PCC commit was including the versions file alongside whichever catalogs changed. This locked out future regeneration for the remaining catalogs since PCC_CACHE_VALID=YES. Now the commit logic checks if ALL new versions are present in ALL catalog files. Only commits the versions file when fully consistent. Partial updates commit changed catalogs without the versions file, so the next run retries for the remaining catalogs. Fixes: RHOAIENG-74801
crackcodecamp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When component bundles are published to production, the Red Hat operator indexes for each OCP version don't all update at the same time. Some indexes get the new version quickly, others lag. The PCC regeneration commits whatever catalogs changed, along with the versions file — even if only 2 of 9 catalogs were updated. This locks out future regeneration for the remaining 7 catalogs (PCC_CACHE_VALID=YES since the versions file was committed).
This happened twice:
Both required manual reverts to unblock.
Fix
Decouple catalog commits from the versions file:
pcc/catalog-*.yamlfiles (notgit add -A)Partial updates commit what's ready without locking out future regeneration. The next run re-detects the gap and retries.
Test results (local simulation)
Fixes: RHOAIENG-74801