Alternative second ad placement for revshare partners#696
Conversation
This adds a second possible ad placement for revenue share partners. Still only a single placement will be selected, but this change offers a second possible placement in the footer with a larger placement.
I spoke with the pallets team directly. The other main revshare partner is Celery. |
|
Should we follow up w/ Celery on the payout email thread perhaps? |
|
I'm good to merge this as well if we want -- I don't think Celery cares too much. |
|
I'll try to get the merge conflict fixed today, but I'd love a review from @humitos. |
|
I tried this locally but I wasn't able to make it work. I'm not sure how to make the new ad placement to appear. How do I reproduce this behavior locally? By the way, do you have an screenshot on how it looks on our theme and Alabaster themes? |
Since the devserver requests a paid ad and there's no large format paid ads, it's not showing. I'll see if I can setup a better example. Edit: I added a second placement in the |
Adds a second possible ad placement for revenue share partners only. Still only a single placement will be selected, but this change offers a second possible placement in the footer with a larger placement. The server will decide which placement to choose based on inventory.
Branched from #695