Skip to content

XF10-814 : WebUI.Enable = MSOonly is not opening MSO GUI#138

Merged
SanthoshGujulvajagadeesh merged 1 commit into
developfrom
XF10_814
Jun 25, 2026
Merged

XF10-814 : WebUI.Enable = MSOonly is not opening MSO GUI#138
SanthoshGujulvajagadeesh merged 1 commit into
developfrom
XF10_814

Conversation

@Leela-Charumathi

Copy link
Copy Markdown
Contributor

XF10-814 : WebUI.Enable = MSOonly is not opening MSO GUI

Reason for change: Added EPON Capabilities for MSO to work
Test Procedure: MSO page should be able to open and login
Risks: Low
Priority: P1

Reason for change: Added EPON Capabilities for MSO to work
Test Procedure: MSO page should be able to open and login
Risks: Low
Priority: P1

Signed-off-by: lm352 <[email protected]>
@Leela-Charumathi Leela-Charumathi requested a review from a team as a code owner June 25, 2026 08:45
Copilot AI review requested due to automatic review settings June 25, 2026 08:45
@Leela-Charumathi Leela-Charumathi requested a review from a team as a code owner June 25, 2026 08:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the XB3 and XB6 WebUI templates to treat EPON/XGSPON WAN-active status as a valid “WAN IP” source for MSO access detection, so WebUI.Enable = MSOonly correctly allows opening the MSO GUI in those deployments.

Changes:

  • Read Device.X_RDK_WanManager.InterfaceActiveStatus to detect EPON/XGSPON active WAN.
  • When EPON/XGSPON is active, use Device.DeviceInfo.X_COMCAST-COM_WAN_IP(/v6) for WAN IP comparison (same as Ethernet WAN-enabled path).
  • Apply the same logic in both XB6 login/index and XB3 header include.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
source/Styles/xb6/jst/index.jst Add WAN active-status check and use it to select the correct WAN IP source for MSO detection.
source/Styles/xb3/jst/includes/header.jst Mirror the EPON/XGSPON WAN IP selection logic for MSO detection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/Styles/xb6/jst/index.jst
Comment thread source/Styles/xb6/jst/index.jst
Comment thread source/Styles/xb3/jst/includes/header.jst

@vysakhav vysakhav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SanthoshGujulvajagadeesh SanthoshGujulvajagadeesh merged commit 23df677 into develop Jun 25, 2026
10 checks passed
@SanthoshGujulvajagadeesh SanthoshGujulvajagadeesh deleted the XF10_814 branch June 25, 2026 15:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants