VPAAMP-1121: Handle partial-ad fallback in UpdateStartTimeOfFirstPTS

[srikanthreddybijjam-comcast]

Reason for change: Added mBaseperiodOffset to mStartTimeOfFirstPTS for a partial ad
Test Procedure: Refer jira ticket VPAAMP-1121
Priority: P1

[Copilot]

🟡 Changes recommended

The new partial-ad fallback branch lacks corresponding unit-test coverage and also removes the prior non-ad fallback log signal when mBasePeriodOffset is not applied.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates DASH (MPD) stream handling in StreamAbstractionAAMP_MPD::UpdateStartTimeOfFirstPTS() to better handle CDAI partial-ad fallback scenarios by offsetting the computed first-PTS start time.

Changes:

• Add mBasePeriodOffset (seconds) to mStartTimeOfFirstPTS (ms) when ad start time is unavailable (partial-ad fallback path).
• Add an INFO log when the base-period offset fallback is applied.

File summaries

File	Description
fragmentcollector_mpd.cpp	Adjusts mStartTimeOfFirstPTS calculation for partial-ad fallback using mBasePeriodOffset.

Review details

Suppressed comments (1)

fragmentcollector_mpd.cpp:10413

• The previous warning log for the non-ad path was removed; when adStartTimeSec < 0 and mBasePeriodOffset <= 0 this now becomes silent, which reduces observability when adPeriodOffset/ad timing is not available. Consider keeping a log for the "no ad start time" fallback when the base-period offset is not applied.

			if (mBasePeriodOffset > 0)
			{
				mStartTimeOfFirstPTS += (mBasePeriodOffset * 1000.0);
				AAMPLOG_INFO("UpdateStartTimeOfFirstPTS (partial ad fallback): +mBasePeriodOffset=%lf sec : mStartTimeOfFirstPTS=%.0f ms",
					mBasePeriodOffset, mStartTimeOfFirstPTS);

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.