VPAAMP-1127: Fragment is skipped when the live manifest refreshes without update - #1939
Merged
Conversation
…hout update Reason for change: When the manifest refreshes without update, FindPositionInTimeline wrongly calculates the position in the timeline. Risks: Low Test Procedure: Test with L1. Priority: P1 Signed-off-by: Nandakishor U M <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a live-DASH (MPD) edge case where a manifest refresh that doesn’t add new SegmentTimeline entries can cause FindPositionInTimeline() to compute the next position incorrectly, leading to a skipped fragment.
Changes:
- Adjust
FindPositionInTimeline()’s “first segment” special-case so it doesn’t trigger when the timeline only contains a single entry. - Add an L1 unit test covering the single-entry timeline boundary case after a manifest refresh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
fragmentcollector_mpd.cpp |
Narrows the “first segment” bypass condition in FindPositionInTimeline() to avoid misbehavior when SegmentTimeline has exactly one entry. |
test/utests/tests/fragmentcollector_mpd/fragmentcollector_mpd1.cpp |
Adds a regression test asserting correct position/descriptor updates for a single-entry SegmentTimeline refresh scenario. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cpc005
approved these changes
Sep 2, 2026
Add comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: When the manifest refreshes without update, FindPositionInTimeline wrongly calculates the position in the timeline.
Risks: Low
Test Procedure: Test with L1.
Priority: P1
Signed-off-by: Nandakishor U M [email protected]