Skip to content

RDKCOM-5599: RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3 - #1199

Merged
narendradandu merged 1 commit into
rdkcentral:developfrom
SsandhyaR:kernel_6_12
Jul 2, 2026
Merged

RDKCOM-5599: RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3#1199
narendradandu merged 1 commit into
rdkcentral:developfrom
SsandhyaR:kernel_6_12

Conversation

@SsandhyaR

Copy link
Copy Markdown
Contributor

Reason for change: In Latest build of Kernel_6_12, below issues are seen | ../../../git/source/core/../../source/apps/levl/wifi_levl.c:518:30: error: 'EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK' undeclared (first use in this function)
| 518 | if (!(sta_ctrl & EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK)) {
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/../../git/source/core/../../source/apps/levl/wifi_levl.c:505:34: error: 'EHT_ML_SUB_ELEM_PER_STA_PROFILE' undeclared (first use in this function); did you mean 'MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE'?
| 505 | for_each_element_id(sub, EHT_ML_SUB_ELEM_PER_STA_PROFILE, sub_start, sub_len)
| |
Test procedure : bitbake ccsp-one-wifi, wifi connectivity should work in
kernel-6.12
Risks: Low

Copilot AI review requested due to automatic review settings June 16, 2026 13:58
@SsandhyaR
SsandhyaR requested a review from a team as a code owner June 16, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes build breaks on kernel 6.12 by switching to renamed/moved 802.11 EHT/MLO constants for a specific platform configuration.

Changes:

  • Adds kernel/platform-conditional compilation to use MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE instead of EHT_ML_SUB_ELEM_PER_STA_PROFILE.
  • Adds kernel/platform-conditional compilation to use BASIC_MLE_STA_CTRL_PRES_STA_MAC instead of EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/apps/levl/wifi_levl.c Outdated
Comment thread source/apps/levl/wifi_levl.c Outdated
Comment thread source/apps/levl/wifi_levl.c Outdated
Comment thread source/apps/levl/wifi_levl.c Outdated
Copilot AI review requested due to automatic review settings June 19, 2026 12:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread source/apps/levl/wifi_levl.c
Comment thread source/apps/levl/wifi_levl.c
Copilot AI review requested due to automatic review settings June 23, 2026 04:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@gsathish86

Copy link
Copy Markdown
Contributor

@SsandhyaR
Is this kernel 6.12 change have backward compatibility with other kernel versions ?

@SsandhyaR SsandhyaR changed the title RDKBACCL-1879 : Upstream Onewifi changes for MP4.3 RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3 Jun 24, 2026
@SsandhyaR

Copy link
Copy Markdown
Contributor Author

@SsandhyaR Is this kernel 6.12 change have backward compatibility with other kernel versions ?

yes

@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3 RDKCOM-5599: RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3 Jun 25, 2026
@AkhilaReddyK7 AkhilaReddyK7 added the community contribution Contributions from community. label Jun 30, 2026
Reason for change: In Latest build of Kernel_6_12, below issues are seen
| ../../../git/source/core/../../source/apps/levl/wifi_levl.c:518:30: error: 'EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK' undeclared (first use in this function)
|   518 |             if (!(sta_ctrl & EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK)) {
|       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/../../git/source/core/../../source/apps/levl/wifi_levl.c:505:34: error: 'EHT_ML_SUB_ELEM_PER_STA_PROFILE' undeclared (first use in this function); did you mean 'MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE'?
|   505 |         for_each_element_id(sub, EHT_ML_SUB_ELEM_PER_STA_PROFILE, sub_start, sub_len)
|       |
Test procedure : bitbake ccsp-one-wifi, wifi connectivity should work in
kernel-6.12
Risks: Low

Signed-off-by: ssiras826 <[email protected]>
@narendradandu
narendradandu merged commit 83ca200 into rdkcentral:develop Jul 2, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community contribution Contributions from community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants