My first pull request#5
Open
APGRoboCop wants to merge 769 commits into
Open
Conversation
pongo1231
pushed a commit
to pongo1231/rcbot2
that referenced
this pull request
Jun 13, 2021
We use a link to build_info to avoid regenerating every file depending on bot_const.h after every update. Versioning based off of SourceMod. Closes rcbotCheeseh#5.
- Snipers will no longer use "sniper" waypoint type with bows
sv_quota_stringcmdspersecond is in the wrong place. this can cause a crash if the server decides to kick a bot
fix config
>> Add availability check for SourceMod entity-property helpers (CBotEntProp::isAvailable) and skip bot thinking until entprops are ready to prevent null-deref crashes. >> Include entprops header in bot code. >> Replace several function-static variables with proper stack locals (bot schedule, waypoint navigator) and make task state local/const to avoid shared state and potential bugs >> Make CBotSchedule non-copyable to prevent double-free, and initialize CCounterStrikeSourceMod::m_hBomb via default construction instead of NULL >> Miscellaneous small refactors and comments explaining the changes
Attempting to resolve issue #55 but requires some tests from our testers.
Make per-bot debugging usable by auto-selecting the bot the player is aiming at, and add a route-size accessor for navigator debugging
Introduce a new waypoint subcommand 'reachable' that performs a flood-fill (DFS) from the player's current waypoint following outgoing paths. The command highlights every reachable node with a green debug overlay, reports the total number of reachable nodes, and prints per-flag node reachability (useful for diagnosing CTF connectivity). It validates the player's waypoint, updates the current waypoint, and registers the command in WaypointSubcommands.
#57 : sprint was effectively dead -- it required danger >=20 AND aux power >90, so the bot only sprinted at near-full suit power and only when the danger metric spiked (rare). One brief sprint dropped power below 90 and it never sprinted again. Sprint whenever there's an enemy (or real danger), and we hold a usable chunk of power. (m_flSuitPower resolves fine -- nested under m_HL2Local, found by the recursive prop search.)
https: //github.com/caxanga334/rcbot2/commit/8c316e0a0eebfdcfab52f676cb2adbe7f13b39e9#diff-1e8da8a2801bb6b05612a775898322d6d304300e975d705dfbc491b229eee15c Co-Authored-By: caxanga334 <[email protected]>
This "hl2_sprintspeed" is similar to caxanga334's "hl2_normspeed" but adapted for sprinting. Co-Authored-By: caxanga334 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is how you do a proper pull request, but let me know if thats how its done!