Fix RBI NACH scraping to capture bank_code and bank_name correctly#459
Open
PriyankaMarbill wants to merge 4 commits into
Open
Fix RBI NACH scraping to capture bank_code and bank_name correctly#459PriyankaMarbill wants to merge 4 commits into
PriyankaMarbill wants to merge 4 commits into
Conversation
RBI added a Bank Name column (index 2) to the NACH participation table, shifting column indices for MICR/IFSC/IIN/ACH onwards. The scraper was reading the wrong columns for bank_code and silently dropping bank_name. Also, RBI periodically renames columns in the RTGS/NEFT CSV exports (e.g. "IFSC Code" instead of "IFSC", "Bank Name" instead of "BANK"). The CSV parser now normalises column names via an alias map so column renames no longer silently drop data. Changes: - methods_nach.rb: capture bank_name from data[2] (new RBI column) and pass it through bank_data; parse_nach extracts it per row - methods.rb: add RBI_HEADER_ALIASES + helpers to normalise CSV column names; update parse_csv to build a header map on first data row; add normalize_bank_name_for_guidelines to apply CONTRIBUTING.md rules mechanically; add export_banknames to emit data/banknames.json with the most-frequent RBI name per bank code merged with existing src/banknames.json; update merge_dataset to prefer the RBI-supplied bank name over the static lookup; update parse_imps to fall back to NACH bank_name for codes not yet in banknames.json; fix IFSC skip check to also handle "IFSC Code" header rows mid-sheet - generate.rb: call export_banknames after dataset is built - CONTRIBUTING.md: note that the scraper auto-applies name guidelines Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RBI added a Bank Name column (index 2) to the NACH participation table, shifting column indices for MICR/IFSC/IIN/ACH onwards. The scraper was reading the wrong columns for bank_code and silently dropping bank_name.
Also, RBI periodically renames columns in the RTGS/NEFT CSV exports (e.g. "IFSC Code" instead of "IFSC", "Bank Name" instead of "BANK"). The CSV parser now normalises column names via an alias map so column renames no longer silently drop data.
Changes:
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.