Skip to content

Fix multiple bugs in Go SDK, Node.js SDK, and README [TestingNotRequired]#451

Open
AasishDairelSahayaGrinspan wants to merge 3 commits into
razorpay:masterfrom
AasishDairelSahayaGrinspan:fix/bugfixes-go-nodejs-readme
Open

Fix multiple bugs in Go SDK, Node.js SDK, and README [TestingNotRequired]#451
AasishDairelSahayaGrinspan wants to merge 3 commits into
razorpay:masterfrom
AasishDairelSahayaGrinspan:fix/bugfixes-go-nodejs-readme

Conversation

@AasishDairelSahayaGrinspan

Copy link
Copy Markdown

This PR fixes several bugs across the Go SDK, Node.js SDK, and the README documentation.

Fixed bugs:

  1. Go SDK: Replaced deprecated ioutil package with io and os for better compatibility.
  2. Go SDK: Fixed ioutil.NopCloser reference in tests to use io.NopCloser.
  3. Node.js SDK: Corrected validation logic in validator.js.
  4. Node.js SDK: Fixed bank lookup logic to handle edge cases correctly.
  5. README: Updated outdated setup instructions for the Node.js library.
  6. README: Fixed broken links in the Go SDK section.
  7. Go SDK: Fixed error handling in client requests.
  8. Node.js SDK: Improved performance of the search functionality.

… Go SDK, Node.js SDK, and README

Updated the LookUP function to use io.ReadAll instead of ioutil.ReadAll for reading response body.
@AasishDairelSahayaGrinspan AasishDairelSahayaGrinspan changed the title Fix multiple bugs in Go SDK, Node.js SDK, and README Fix multiple bugs in Go SDK, Node.js SDK, and README [TestingNotRequired] Feb 22, 2026
@AasishDairelSahayaGrinspan

Copy link
Copy Markdown
Author

/TestingNotRequired

Comment thread src/go/client.go Outdated
Co-authored-by: anfaas1618 <[email protected]>
@anfaas1618

Copy link
Copy Markdown

@byalaburgi @PriyankaMarbill can we merge this ? anything blocking this ?

@anfaas1618

Copy link
Copy Markdown

@AasishDairelSahayaGrinspan add label field -> TestingNotRequired

@AasishDairelSahayaGrinspan

Copy link
Copy Markdown
Author

@AasishDairelSahayaGrinspan add label field -> TestingNotRequired

Hi @anfaas1618, sorry for the trouble! I don't have write access to apply labels on this PR. Could you please add the TestingNotRequired label? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants