Skip to content

feat: indicator classNames and sidebar overflow #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 4 commits into from
May 11, 2026
+17 −7
Merged

feat: indicator classNames and sidebar overflow #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fde2a55
feat: indicator classNames and sidebar overflow
rohanchkrabrty May 11, 2026
8f071fd
feat: update indicator docs
rohanchkrabrty May 11, 2026
0abbd76
feat: update indicator
rohanchkrabrty May 11, 2026
cb4bbf0
fix: sidebar css
rohanchkrabrty May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/www/src/content/docs/components/indicator/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,10 @@ export interface IndicatorProps {

/** Additional CSS class names */
className?: string;

/** Map of classNames for internal components */
classNames?: {
Comment thread
rohanchkrabrty marked this conversation as resolved.
/** Class for the outer container element */
container?: string;
};
Comment thread
rohanchkrabrty marked this conversation as resolved.
}
8 changes: 6 additions & 2 deletions packages/raystack/components/indicator/indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { cva, VariantProps } from 'class-variance-authority';
import { cva, cx, VariantProps } from 'class-variance-authority';
import { ComponentProps, ReactNode } from 'react';

import styles from './indicator.module.css';
Expand All @@ -24,10 +24,14 @@ export interface IndicatorProps
label?: string;
children?: ReactNode;
'aria-label'?: string;
classNames?: {
container?: string;
};
}

export const Indicator = ({
className,
classNames,
variant,
label,
children,
Expand All @@ -37,7 +41,7 @@ export const Indicator = ({
const accessibilityLabel = ariaLabel || label || `${variant} indicator`;

return (
<div className={styles.wrapper} {...props}>
<div className={cx(styles.wrapper, classNames?.container)} {...props}>
{children}
<div
className={indicator({ variant, className })}
Expand Down
10 changes: 5 additions & 5 deletions packages/raystack/components/sidebar/sidebar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
display: flex;
width: 220px;
height: 100%;
padding: var(--rs-space-5) var(--rs-space-4);
padding: var(--rs-space-5) 0;
flex-direction: column;
justify-content: flex-start;
align-items: flex-start;
Expand Down Expand Up @@ -42,18 +42,17 @@

.header {
gap: var(--rs-space-3);
padding: var(--rs-space-2);
padding: var(--rs-space-2) var(--rs-space-5) var(--rs-space-7);
align-self: stretch;
border-radius: var(--rs-radius-2);
background: var(--rs-color-background-base-primary);
overflow: hidden;
margin-bottom: var(--rs-space-6);
}

.main {
flex: 1;
overflow-y: auto;
width: 100%;
align-self: stretch;
padding: 0 var(--rs-space-4);
gap: var(--rs-space-6);
align-items: flex-start;
}
Expand All @@ -68,6 +67,7 @@

.footer {
width: 100%;
padding: 0 var(--rs-space-4);
gap: var(--rs-space-2);
}

Expand Down
Loading