fix: Select set align default to bottom-start#798
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR refactors the Select component's content positioning API from a single Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/V1-migration.md`:
- Around line 1391-1399: Update the migration note that currently equates
"bottom-start" with "bottom-left" to be direction-aware: change the phrasing
around Select.Content so it explains "bottom-start" aligns to the trigger's
start edge (left in LTR, right in RTL) rather than hardcoding "bottom-left", and
keep the guidance to pass align="center" to restore the previous centered
behavior; reference the Select.Content usage and the align="center" example so
readers know where to apply the opt-in.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 11ced194-496d-426b-b390-dee702ca7bf0
📒 Files selected for processing (3)
apps/www/src/content/docs/components/select/props.tsdocs/V1-migration.mdpackages/raystack/components/select/select-content.tsx
Summary
Select.Contentalignment changed from bottom-center to bottom-start so the popup opens flush with the trigger's start edge.size={12}on the combobox-mode input so the search field doesn't collapse inside the positioner.align="center") in the V1 migration guide.