Skip to content

fix: Select set align default to bottom-start#798

Merged
rohanchkrabrty merged 1 commit into
mainfrom
fix-select-position
May 11, 2026
Merged

fix: Select set align default to bottom-start#798
rohanchkrabrty merged 1 commit into
mainfrom
fix-select-position

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

@rohanchkrabrty rohanchkrabrty commented May 11, 2026

Summary

  • Default Select.Content alignment changed from bottom-center to bottom-start so the popup opens flush with the trigger's start edge.
  • Set size={12} on the combobox-mode input so the search field doesn't collapse inside the positioner.
  • Document the alignment default change and opt-out (align="center") in the V1 migration guide.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 11, 2026 5:50am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR refactors the Select component's content positioning API from a single position property to a three-property model comprising side, align, and sideOffset. The type definition in SelectContentProps removes the position option and introduces these three new properties to provide more granular control over where content renders relative to the trigger. The SelectContent component implementation applies defaults of bottom and start alignment, then forwards these values to both the autocomplete (ComboboxPrimitive) and standard (SelectPrimitive) render paths. A migration guide is added to document the behavior change and show how to restore prior v0 alignment if needed.

Suggested reviewers

  • rohilsurana
  • rsbh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: defaulting Select content alignment to bottom-start. It's concise, specific, and clearly summarizes the primary fix without unnecessary details.
Description check ✅ Passed The PR description accurately describes the changeset, covering all three main changes: alignment default change, input size fix, and documentation update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title fix(select): expose side/align props and default to bottom-start fix: Select set align default to bottom-start May 11, 2026
@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) May 11, 2026 05:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/V1-migration.md`:
- Around line 1391-1399: Update the migration note that currently equates
"bottom-start" with "bottom-left" to be direction-aware: change the phrasing
around Select.Content so it explains "bottom-start" aligns to the trigger's
start edge (left in LTR, right in RTL) rather than hardcoding "bottom-left", and
keep the guidance to pass align="center" to restore the previous centered
behavior; reference the Select.Content usage and the align="center" example so
readers know where to apply the opt-in.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11ced194-496d-426b-b390-dee702ca7bf0

📥 Commits

Reviewing files that changed from the base of the PR and between a2e3400 and fbd343e.

📒 Files selected for processing (3)
  • apps/www/src/content/docs/components/select/props.ts
  • docs/V1-migration.md
  • packages/raystack/components/select/select-content.tsx

Comment thread docs/V1-migration.md
@rohanchkrabrty rohanchkrabrty merged commit 3056907 into main May 11, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-select-position branch May 11, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants