Skip to content

Proposal 1: Preserve original date and filename if nothing else has changed - #130

Closed
markus-codechefs wants to merge 5 commits into
rappen:masterfrom
markus-codechefs:feature/generatefileifactualchangewasmade
Closed

Proposal 1: Preserve original date and filename if nothing else has changed#130
markus-codechefs wants to merge 5 commits into
rappen:masterfrom
markus-codechefs:feature/generatefileifactualchangewasmade

Conversation

@markus-codechefs

Copy link
Copy Markdown

Assuming the file exists as it has been generated in a previous run, we check the original time and location (different users save their repo in different paths) and restore those if no actual attribure changes have been generated.

An alternative would be to no generate a file if no new content has been detected. Do tell me if you prefer that approach.

Testing

I added 3 tests which support my code. I have not been able to verify if the plugin would work as I do not have the necessary setup. How do you test your versions?

Trachsel Markus, BKW (ext.) added 5 commits September 3, 2025 17:47
@rappen

rappen commented Oct 22, 2025

Copy link
Copy Markdown
Owner

I'm sorry that I haven't looked at this yet.
Thanks @markus-codechefs for your ping, I will drill down into it soon!

@markus-codechefs

Copy link
Copy Markdown
Author

@rappen any update? :)

@rappen

rappen commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Ouch, I'm sorry, this tool has been idle for too long time... 😕
I WILL take a look at it soon! Promise.

@markus-codechefs

markus-codechefs commented Jun 5, 2026 via email

Copy link
Copy Markdown
Author

@rappen

rappen commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Small comments:

  1. While checking the changes you made, we see that you have another format, e.g., that if should not get a space after. Just a bit harder to see what has actually been changed.
  2. FileHeaderConstants.cs is in three places, but only seems to be used from one place.

Nothing needed to do, just FYI :)

@rappen

rappen commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Obviously, I am no expert on Git...
I downloaded your PR, tested, changed a few small stuff, and tried to update this PR, but that failed, and instead it created a new PR... 🙄
So I will just close this one and accept PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants