Fix MacOS CI#295
Open
jbx81-1337 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the fs_mkdir implementation to be safer on macOS/clang by reducing unsafe string formatting and centralizing buffer sizing for path construction.
Changes:
- Introduces a single computed max buffer length (
base_max_len) forbase_dir/tmpallocations. - Replaces
sprintfcalls with boundedsnprintfwhen building intermediate directory paths.
Impact Analysis:
- Blast radius: medium—affects directory-creation behavior for the stdapi filesystem “mkdir” handler and any downstream callers that rely on it; exact external consumers Unknown from diff.
- Data and contract effects: no schema/payload changes identified; behavior can change on edge-case paths (e.g., root/empty components) and for very long paths if sizing/truncation occurs.
- Rollback and test focus: easy rollback (single function change); validate mkdir with absolute + relative paths, nested paths, trailing slashes, and the
"/"edge case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing macos ci...