Provisioning CAPI downstream cluster#543
Conversation
slickwarren
left a comment
slickwarren
left a comment
There was a problem hiding this comment.
just wondering if this is exclusive to harvester / behind the vpn or if you want it to work with other providers
floatingman
left a comment
floatingman
left a comment
There was a problem hiding this comment.
I'm mostly concerned with the cleanup of AWS resources.
| def capiAnsibleConfig = env.CAPI_ANSIBLE_CONFIG | ||
| def capiConfigFile = "capiconfig.yaml" | ||
| def capiClusterConfigFile = "capiclusterconfig.yaml" | ||
| def harvesterConfigfilename = "local.yaml" |
There was a problem hiding this comment.
I don't think this is used anywhere.
| } | ||
| } | ||
|
|
||
| stage('Cleanup Rancher Environment') { |
There was a problem hiding this comment.
Does this stage cleanup any clusters that may have been made with CAPI?
There was a problem hiding this comment.
Just following up on this question.
There was a problem hiding this comment.
Yes, this stage cleanup the CAPI resources, the turtles clean the resources
89bd426 to
5421c14
Compare
5421c14 to
053da00
Compare
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I don't think it makes sense to have a script to run a single command that basically only works in Jenkins. Why not just run the command with sh?
There was a problem hiding this comment.
To keep the code organized and follow the standard
There was a problem hiding this comment.
Which standard are you referring to? Perhaps I am unaware of this
5 participants
No description provided.