Improved error on missing config key#589
Merged
Merged
Conversation
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
caliskanugur
left a comment
caliskanugur
left a comment
Member
There was a problem hiding this comment.
Looks good, just have couple questions out of curiosity
lscalabrini01
previously approved these changes
Jul 14, 2026
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
This avoids a flood of useless messages on our tests such as: I1217 13:52:49.485450 12406 warnings.go:110] "Warning: child pods are preserved by default when jobs are deleted; set propagationPolicy=Background to remove them or set propagationPolicy=Orphan to suppress this warning" Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
improve_missing_key_error
branch
from
July 15, 2026 19:13
d562cf1 to
4dcaafb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains:
UpdateSecretWithTemplateAlso may contain changes from #513 as it was missing from a few branches,