[main] Updated const for corral-packge conflict on naming#337
Open
MSpencer87 wants to merge 1 commit into
Open
[main] Updated const for corral-packge conflict on naming#337MSpencer87 wants to merge 1 commit into
MSpencer87 wants to merge 1 commit into
Conversation
markusewalker
previously approved these changes
Nov 1, 2024
markusewalker
left a comment
markusewalker
left a comment
Contributor
There was a problem hiding this comment.
LGTM, can you open backports as well?
caliskanugur
reviewed
Nov 1, 2024
markusewalker
self-requested a review
November 1, 2024 16:19
This was referenced Nov 1, 2024
MSpencer87
force-pushed
the
proxy-update-main
branch
from
November 1, 2024 19:27
44db2b4 to
f4ac656
Compare
markusewalker
previously approved these changes
Nov 1, 2024
slickwarren
previously approved these changes
Nov 4, 2024
slickwarren
left a comment
slickwarren
left a comment
Contributor
There was a problem hiding this comment.
imo this should be an action, not an extension. since we're already touching the code maybe it would make sense to move it now. Since this is only used for proxy tests.
MSpencer87
dismissed stale reviews from slickwarren and markusewalker
via
December 6, 2024 22:30
94bd94f
MSpencer87
force-pushed
the
proxy-update-main
branch
from
December 6, 2024 22:30
f4ac656 to
94bd94f
Compare
caliskanugur
left a comment
caliskanugur
left a comment
Member
There was a problem hiding this comment.
Looks good, just have one nit
| corralPublicSSHKey = "corral_public_key" | ||
| corralRegistryIP = "registry_ip" | ||
| corralRegistryPrivateIP = "registry_private_ip" | ||
| debugFlag = "--trace" |
Member
There was a problem hiding this comment.
This one just updated to be the debug flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Conflict between airgap and proxy corral-packages on name for bastion/registry
Solution
renamed to utilize "bastion" over "registry" in corral-package/shepherd
Testing
Jenkins runs for proxy tests
Regressions Considerations
custom cluster provisioning on airgap setup in jenkins