Skip to content

Adding Validate rev-date GH action#55

Open
kakabisht wants to merge 1 commit into
rancher:mainfrom
kakabisht:validate-rev-date
Open

Adding Validate rev-date GH action#55
kakabisht wants to merge 1 commit into
rancher:mainfrom
kakabisht:validate-rev-date

Conversation

@kakabisht

Copy link
Copy Markdown

Adding validate rev-date GH Action

@kakabisht
kakabisht requested a review from a team as a code owner May 21, 2026 11:00

@pmkovar pmkovar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!


ancestor=$(git merge-base origin/${{ github.base_ref }} HEAD)

helpers/scripts/recurring/validate_rev-date.sh \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the path be ./product-docs-common/scripts/recurring/validate_rev-date.sh when run from a docs repo?

id: update-revdate
continue-on-error: true
env:
GH_TOKEN: ${{ inputs.token }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, as discussed on Slack, there is this recurring issue with unverified commits on protected branches, so as a workaround we would need to squash commits on PR merge that makes it verified or disable the rule that requires verified commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants