small aws qol updates#185
Closed
MSpencer87 wants to merge 3 commits into
Closed
Conversation
MSpencer87
commented
May 18, 2026
MSpencer87
commented
Contributor
- added support for aws keys
- allows public agents
MSpencer87
force-pushed
the
aws-qol-updates
branch
from
May 19, 2026 18:17
fa2c61f to
a2d7374
Compare
git-ival
requested changes
May 21, 2026
git-ival
left a comment
git-ival
left a comment
Member
There was a problem hiding this comment.
We should not include secret key inputs as they would be stored in the terraform state files which could be exposed. Also, there are multiple alternatives for providing authentication creds to the provider that are more secure.
| profile = var.aws_profile | ||
| region = var.region | ||
| profile = var.aws_profile | ||
| access_key = var.aws_access_key |
Member
There was a problem hiding this comment.
Providing AWS credentials in this way is insecure and actually unnecessary. See:
| node_module = var.node_module | ||
| node_module_variables = var.node_module_variables | ||
| network_config = var.network_config | ||
| public = var.public |
Member
There was a problem hiding this comment.
Do the agent nodes need public addresses? Our network configurations ensure that all nodes can communicate with each other via private addresses already. I'm not sure we would need to access agent nodes publically.
Contributor
Author
|
Closing this, changes are either unnecessary or obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.