Add support for binary compression of widget data#498
Open
andrjohns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating files with multiple widgets and large input data, the resulting HTML filesize is dominated by the embedded JSON data.
This PR introduces the option (disabled by default):
htmlwidget.compress_payload, to store widget data as a compressed binary string. Decompression is handled by thefflatelibrary - only theunzlibSyncandstrFromU8functions are bundled, resulting in only 5kb (minified) added to the output.In our local testing this reduced the output size for one of our HTML files from 55mb -> 10mb, with little lag in the initial rendering time.
Let me know if I've missed anything, or if there's a better way to do this, thanks!