Refactor/s4 paths - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #28
Summary
scripts/config/paths.ts— 24 pure, cwd-based path helpers covering every pipeline stage(transcribe, edit, sync, camera, shorts, carousel, thumbnail). No filesystem reads, all helpers
default
cwdtoprocess.cwd()..ragtech/paths by importingPROJECT_DIR/PROJECT_FILENAMEfromproject.tsandARTIFACTS_DIRfromartifacts.tsinsteadof hardcoding the strings again.
transcribeRawDir,carouselDir) are kept private — onlyfile/artifact paths are exported, so the public API surface is stable for later script migrations.
ws >= 8.21.0andbrace-expansion >= 5.0.6inpackage.jsonoverrides to clear 7moderate npm audit vulnerabilities that were blocking the pre-push hook.
How to review
scripts/config/paths.tsedit-transcript.js,shorts-wizard.js,carousel-wizard.js, etc.). Private helpers have noexport.projectFile/artifactDirshortClipDir/carouselClipDirforid.scripts/config/paths.test.tspath.join)RangeErroronsyncedVideoAngle(0)andTypeErroron emptyid.cwd defaultstest usesstartsWith/endsWith, not a tautologicalpackage.jsonoverridesblock changed — two entries added. No dependency versionsTest plan
npm testpasses (30 new unit tests inpaths.test.ts, all green)npm run test:reactpasses (if React/Remotion components changed)npm run test:e2epasses (if Phase 8 user-facing flows changed)Manual verification:
Checklist
tsc --noEmitpassesscripts/; no new duplicated timing constants inremotion/scripts/config/paths.ts,scripts/config/paths.test.ts, andpackage.json(overrides) touched