Skip to content

Fix: Applications.Core/gateways can hang deploying contour httpproxy route child before root 12259#12282

Open
gergo-hortobagyi wants to merge 6 commits into
radius-project:mainfrom
gergo-hortobagyi:fix/applicationscoregateways-can-hang-deploying-contour-httpproxy-route-child-before-root--12259
Open

Fix: Applications.Core/gateways can hang deploying contour httpproxy route child before root 12259#12282
gergo-hortobagyi wants to merge 6 commits into
radius-project:mainfrom
gergo-hortobagyi:fix/applicationscoregateways-can-hang-deploying-contour-httpproxy-route-child-before-root--12259

Conversation

@gergo-hortobagyi

Copy link
Copy Markdown

Description

This pull request fixes a deployment hang for Applications.Core/gateways that render Contour HTTPProxy route-child resources before the root gateway HTTPProxy.

Contour route-child HTTPProxy resources do not become independently valid until the root HTTPProxy includes them, so Radius should not wait for each route child to report readiness immediately after applying it. This change skips readiness waits for Contour route-child HTTPProxy resources while preserving readiness validation for root Contour HTTPProxy resources.

The change also adds regression coverage for:

  • ordering gateway output resources so route-child HTTPProxy resources are applied before the root HTTPProxy
  • identifying Contour route-child HTTPProxy resources
  • ensuring route-child HTTPProxy resources bypass the readiness waiter
  • ensuring root Contour HTTPProxy resources still wait for readiness
  • ensuring non-Contour resources named HTTPProxy are not sent through the Contour waiter

Validation performed:

  • Deployed the issue repro in a real kind cluster with the branch applications-rp image; the deployment completed and all generated Contour HTTPProxy resources became valid.
  • go test -count=1 ./pkg/corerp/renderers/gateway ./pkg/corerp/handlers ./pkg/rp/v1
  • make build
  • Helm unit tests
  • Full ./pkg/... test sweep with arm64 envtest assets
  • make lint

Type of change

Fixes: #12259

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document is added or updated under eng/design-notes/ in this repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for resource-types-contrib is created, if resource types or recipes are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for dashboard is created, if the Radius Dashboard is affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable

Copilot AI review requested due to automatic review settings June 27, 2026 20:02
@gergo-hortobagyi gergo-hortobagyi requested review from a team as code owners June 27, 2026 20:02
@gergo-hortobagyi gergo-hortobagyi requested a deployment to external-contributor-approval June 27, 2026 20:02 — with GitHub Actions Waiting
…ing-contour-httpproxy-route-child-before-root--12259

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a deployment hang when applying Applications.Core/gateways resources backed by Contour by ensuring route-child HTTPProxy resources do not block deployment readiness while still validating readiness for the root HTTPProxy.

Changes:

  • Skip readiness waiting for Contour route-child HTTPProxy resources; continue waiting for root Contour HTTPProxy readiness.
  • Add a Contour-aware guard so non-Contour resources with kind: HTTPProxy bypass the Contour waiter entirely.
  • Add regression tests covering output-resource ordering, route-child detection, and waiter behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/corerp/renderers/gateway/render_test.go Adds a regression test asserting route-child HTTPProxy output resources are ordered before the root gateway HTTPProxy.
pkg/corerp/handlers/kubernetes.go Updates the Kubernetes handler to only invoke the Contour HTTPProxy waiter for Contour resources, and to skip waits for route-child HTTPProxy resources.
pkg/corerp/handlers/kubernetes_test.go Adds tests verifying route-child HTTPProxy skips waiting, root HTTPProxy still waits, and non-Contour HTTPProxy bypasses the waiter.
pkg/corerp/handlers/kubernetes_http_proxy_waiter.go Introduces Contour HTTPProxy/route-child identification helpers and uses them to avoid validating route-child readiness.
pkg/corerp/handlers/kubernetes_http_proxy_waiter_test.go Adds unit tests for route-child detection and for ensuring root invalid status is still surfaced as an error.

@gergo-hortobagyi gergo-hortobagyi requested a deployment to external-contributor-approval June 30, 2026 20:11 — with GitHub Actions Waiting
…ing-contour-httpproxy-route-child-before-root--12259
@gergo-hortobagyi gergo-hortobagyi requested a deployment to external-contributor-approval July 2, 2026 21:24 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applications.Core/gateways can hang deploying Contour HTTPProxy route child before root

3 participants