Fix 0.8.1 follow-up regressions#149
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR implements v0.8.1 with six behavioral fixes: GraphQL entity-not-found errors now map to the not-found exit code and category; command registrations consolidate with global option groups to enable ChangesGraphQL error classification, command registry consolidation, and command/schema refinements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/core/registry/commands.ts (1)
332-336: ⚡ Quick winRemove duplicate "api-url" from optionKeys.
Line 334 explicitly lists
"api-url", but this key is already included inOPTION_GROUPS.global(line 332). While the parser should handle this gracefully, the duplication is redundant and could cause maintenance confusion.♻️ Proposed fix
optionKeys: [ ...OPTION_GROUPS.global, "api-key-env", "api-key-stdin", "oauth", - "set-default", "remove-config", "api-url", + "set-default", "remove-config", "oauth-client-id", "callback-port", "no-browser", ],🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/registry/commands.ts` around lines 332 - 336, The optionKeys array currently spreads OPTION_GROUPS.global and then redundantly lists "api-url" again; remove the duplicate "api-url" string from the explicit list so the key only comes from OPTION_GROUPS.global. Locate the array (the optionKeys/command options definition that spreads OPTION_GROUPS.global) and delete the extra "api-url" entry to eliminate redundancy.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/core/registry/commands.ts`:
- Around line 332-336: The optionKeys array currently spreads
OPTION_GROUPS.global and then redundantly lists "api-url" again; remove the
duplicate "api-url" string from the explicit list so the key only comes from
OPTION_GROUPS.global. Locate the array (the optionKeys/command options
definition that spreads OPTION_GROUPS.global) and delete the extra "api-url"
entry to eliminate redundancy.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f14a8fd1-317f-4d64-b5c5-dcceb9a56e36
📒 Files selected for processing (13)
CHANGELOG.mdpackage.jsonsrc/commands/api.tssrc/commands/file.tssrc/commands/issue.tssrc/commands/schema.tssrc/core/errors/command-failure.tssrc/core/registry/commands.tstests/cli/main.test.tstests/commands/api.test.tstests/commands/file.test.tstests/commands/issue.test.tstests/commands/schema.test.ts
Summary
Fixes the four 0.8.0 follow-up issues:
Entity not foundfailures as not-found, including bulk per-item failures and exit-code priority--version/--metadata curated --jsonmatrix testissue list --searchscoped to the profile default team while preserving workspace-wideissue searchVerification
bun run typecheckbun run testbun run buildFixes #145
Fixes #146
Fixes #147
Fixes #148
Summary by CodeRabbit
Release Notes v0.8.1
issue list --search.schema pull/schema check.--versionand curated metadata options across commands.