Skip to content

Fix API manifest generator import side effect - #132

Merged
qwrobins merged 1 commit into
mainfrom
codex/fix-manifest-test-race
Jun 10, 2026
Merged

Fix API manifest generator import side effect#132
qwrobins merged 1 commit into
mainfrom
codex/fix-manifest-test-race

Conversation

@qwrobins

@qwrobins qwrobins commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Guards the generated API manifest builder so importing helper functions does not execute the CLI writer.
  • Adds a regression test that imports the module in a Bun subprocess and verifies src/generated/manifest/api-commands.json is unchanged.
  • Bumps version to 0.7.2 and documents the test-race fix.

Verification

  • bun test tests/generated/generate-manifest-import.test.ts tests/generated/generate-manifest.test.ts tests/commands/api.test.ts tests/cli/main.test.ts tests/commands/curated-taxonomy.test.ts
  • bun run typecheck && bun run test && bun run build && bun run build:binary
  • bun run typecheck && bun run build after the version/changelog bump

Summary by CodeRabbit

Bug Fixes

  • Fixed an issue where importing the API manifest builder was inadvertently rewriting the tracked configuration file, causing race conditions and test failures in parallel execution environments, particularly affecting continuous integration pipelines.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0851bd4f-6aa2-4dee-bea3-9557db17321a

📥 Commits

Reviewing files that changed from the base of the PR and between 43c36e0 and 674c8e0.

⛔ Files ignored due to path filters (2)
  • src/generated/generate-manifest.ts is excluded by !**/generated/**
  • tests/generated/generate-manifest-import.test.ts is excluded by !**/generated/**
📒 Files selected for processing (2)
  • CHANGELOG.md
  • package.json

📝 Walkthrough

Walkthrough

This PR releases version 0.7.2 by bumping the package version number and documenting a fix in the changelog: API manifest builder imports no longer rewrite the tracked api-commands.json file, resolving a parallel test race condition.

Changes

Release

Layer / File(s) Summary
Version bump and changelog entry
package.json, CHANGELOG.md
Package version incremented from 0.7.1 to 0.7.2. Changelog entry documents the fix where API manifest builder imports no longer mutate the tracked api-commands.json, eliminating a parallel test race involving commands that import the bundled API manifest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A version released, clean and bright, 🐰
No more test races in the night,
Manifest imports now play fair,
Commands bundled with utmost care! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing an import side effect in the API manifest generator that was causing test race conditions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-manifest-test-race

Comment @coderabbitai help to get the list of available commands and usage tips.

@qwrobins
qwrobins merged commit 5ca5f2a into main Jun 10, 2026
2 checks passed
@qwrobins
qwrobins deleted the codex/fix-manifest-test-race branch June 10, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant