Skip to content

Support Multi-Studyset Practice Tests via Term Mappings#23

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
feat/practice-test-multi-studyset-10523823744295046263
Open

Support Multi-Studyset Practice Tests via Term Mappings#23
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
feat/practice-test-multi-studyset-10523823744295046263

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This change transitions practice tests from a single studyset_id relationship to a many-to-many relationship derived from the terms included in the test.

Key changes:

  • Modified PracticeTest model and GraphQL resolvers to remove direct studyset_id usage.
  • Implemented a new studysetIds field on PracticeTest that queries unique studyset IDs from both question and distractor terms.
  • Updated RecordPracticeTest and UpdatePracticeTest mutations to automatically calculate questionsCorrect and questionsTotal from the provided questions array.
  • Refactored dataloaders to join practice_tests with practice_test_question_terms and practice_test_distractor_terms.
  • Updated integration tests to provide full term objects (ID, term, def) required by the new TermATP type and to reflect the removed studysetId input.

PR created automatically by Jules for task 10523823744295046263 started by @ehanahamed

- Remove studyset_id column from practice_tests table
- Implement StudysetIds resolver to derive studysets from associated terms
- Update RecordPracticeTest and UpdatePracticeTest to calculate stats server-side
- Update dataloaders to fetch practice tests through term mappings
- Update integration tests to match new GraphQL schema and logic
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants