Update pydantic requirement to support pydantic 2.13 - #1142
Open
Robbie-Palmer wants to merge 1 commit into
Open
Conversation
Raise the pydantic cap from <2.13 to <2.14 and pydantic-settings from <2.12 to <2.14 so quixstreams can be installed alongside pydantic 2.13.x. Verified with pydantic 2.13.4 / pydantic-settings 2.13.1: mypy passes and the models, app, kafka, serializer and config test suites pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the dependency caps to allow pydantic 2.13.x:
pydantic>=2.7,<2.13>=2.7,<2.14pydantic-settings>=2.3,<2.12>=2.3,<2.14Changes are mirrored in both
requirements.txtandconda/meta.yaml(kept in sync per the
conda-requirementspre-commit hook).Why
The current
pydantic<2.13cap preventsquixstreamsfrom being installed inenvironments that require
pydantic>=2.13— for example projects pinningpydantic>=2.13.4to avoid pydantic/pydantic#12376.pydantic-settingsisbumped alongside so its aligned 2.12/2.13 releases are usable.
Testing
Verified locally with
pydantic==2.13.4/pydantic-settings==2.13.1:mypypasses (no issues in 213 source files)ruffcheck + format passtest_models,test_app,test_kafka, serializers andconfiguration tests