fix(run-test262): bounds-check optind before argv[optind] for -N#1481
Open
andreasrosdal wants to merge 1 commit into
Open
fix(run-test262): bounds-check optind before argv[optind] for -N#1481andreasrosdal wants to merge 1 commit into
andreasrosdal wants to merge 1 commit into
Conversation
Running `run-test262 -c <conf> -N` without a trailing test file argument
passed `argv[optind]` to `run_test262_harness_test` → `fopen()` with
`argv[argc]` being NULL on POSIX (uninitialised on some libcs),
yielding a "Bad address" error or, on platforms that don't NULL-terminate
argv, an out-of-bounds read.
Reject the missing argument explicitly with `fatal()`.
Manual repro before the fix:
$ build/run-test262 -c tests.conf -N
run-test262: Bad address # NULL fopen
exit code 1
After:
$ build/run-test262 -c tests.conf -N
run-test262: missing test file argument for -N
exit code 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
run-test262 -c <conf> -Nwithout a trailing test file argument passedargv[optind]torun_test262_harness_test→fopen()withargv[argc]being NULL on POSIX (uninitialised on some libcs), yielding a "Bad address" error or, on platforms that don't NULL-terminate argv, an out-of-bounds read.Reject the missing argument explicitly with
fatal().Manual repro before the fix:
After: