Skip to content

test: colocate delegate renderer tests - #105

Merged
zatevakhin merged 1 commit into
refactor/componentsfrom
refactor/phase10-delegate-render-tests
Aug 30, 2026
Merged

test: colocate delegate renderer tests#105
zatevakhin merged 1 commit into
refactor/componentsfrom
refactor/phase10-delegate-render-tests

Conversation

@zatevakhin

Copy link
Copy Markdown
Collaborator

Scope

  • Move seven Delegate-only Ratatui buffer contracts beside draw_tab in src/features/delegates/view/popup.rs.
  • Preserve root UI composition, popup/screen dispatch, cross-feature styling, metric independence, integration, and session-isolation contracts in src/ui/mod.rs.
  • Test-only ownership change: popup.rs +312 and ui/mod.rs -409; production prefixes are byte-identical and the inventory remains 1,173 tests.

The owner tests cover aligned columns, pending markers, zero-cost omission, truncation, failed styling, selected-row highlighting, and agent-name rendering, each moved exactly once.

Review

Linus independently approved the actual change with no findings and deemed it safe to publish and integrate after hosted CI.

Validation

Local validation passed:

  • Delegate owner tests: 7
  • UI tests: 134
  • handlers: 49
  • application: 62
  • runtime: 198
  • repeated all-feature debug and release suites: 1,173 each
  • all-targets, formatting, check, Clippy, build, ownership, scope, and protected-path audits

Live ACP/backend, compatible WebSocket, and interactive terminal smoke testing were unavailable and are not claimed.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b5f9d826-baa0-45d6-9390-fdda3ca00121

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@zatevakhin
zatevakhin merged commit 5f0cf2a into refactor/components Aug 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant