Skip to content

test: colocate delegate input tests - #104

Closed
zatevakhin wants to merge 2 commits into
refactor/componentsfrom
refactor/phase10-delegate-input-tests
Closed

test: colocate delegate input tests#104
zatevakhin wants to merge 2 commits into
refactor/componentsfrom
refactor/phase10-delegate-input-tests

Conversation

@zatevakhin

Copy link
Copy Markdown
Collaborator

Scope

  • Includes d018bbd8bda34dfab6904be723bd59fc0c3e4020 (test: colocate delegate input tests) and follow-up contract fix 5d8c9b73593309e982dfd17e63b571df88bf0e87 (test: preserve delegate navigation contracts).
  • Changes only test code in src/features/delegates/input/view.rs and src/runtime/mod.rs (+219/-88). Production prefixes are byte-identical to the base.
  • Moves pure Delegate input ownership coverage to the owner module while retaining root routing, effect-ordering, popup-lifecycle, fallback-parent, and sibling-parent coordination coverage.

Contracts

  • Owner tests preserve exact PendingChild handling for missing child sessions and exact LoadChild handling for ordinary and PendingElicitation children, including parent staging.
  • Root tests preserve full handle_session_popup_key routing, ordered LoadSession then SubscribeSession effects, popup closure, current-session fallback when catalog parent metadata is absent, and explicit sibling-parent precedence.
  • No production behavior, API, visibility, import, manifest, dependency, or protected path changes are included.

Validation

  • Focused Delegate owner and root runtime suites passed.
  • Debug and release full suites passed twice each: 1,173 tests per run.
  • All-targets, cargo fmt --all -- --check, cargo check, cargo clippy, and cargo build passed.
  • Aggregate diff, exact scope, protected paths, and production-prefix byte identity were verified.

Linus independently approved the corrected aggregate range 568c2f4f411fa4b581fc0803e58d7be84342794e..5d8c9b73593309e982dfd17e63b571df88bf0e87 with no findings and explicitly deemed it safe to publish and squash-integrate after hosted CI. Live ACP/backend and interactive terminal smoke were unavailable and are not claimed. Delegate renderer ownership and Phase 11 work are excluded.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cd6da21b-4dce-445d-b187-bbc9142788b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@zatevakhin

Copy link
Copy Markdown
Collaborator Author

Hosted CI passed and the guarded squash operation created integration commit 22737e2ac04d68f5eba334a0e94e52b60862549d on refactor/components. GitHub returned GraphQL error E76C:3C09FF:D0D0998:CAF9FD2:6A93AD15 after updating the base ref but left the PR open, so this closes the already-integrated PR without rerunning the merge or deleting the retained source branch.

@zatevakhin zatevakhin closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant