test: strengthen new session input contracts - #103
Merged
zatevakhin merged 2 commits intoAug 30, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
69d621f0f64bf83c1f19513e41bc7a34fe0ba042(test: strengthen new session input contracts) and fixture correction73fd73f8f225935d9e7f6a890b0f7ae56450aca3(test: make new session fixture collision-safe).src/features/sessions/input/new_session.rs,src/runtime/mod.rs, andsrc/handlers.rs(+356/-48).Contracts
NewSessionInputResultvariants:Edited,MovedCompletion,AcceptCompletion,Submit,Cancel, andNotHandled.create_dir, retry onlyAlreadyExists, and clean up only a directory it successfully created. This resolves the initial independent fixture-collision ownership finding in a separate commit.Validation
cargo fmt --all -- --checkcargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featuresgit diff --checkand exact scope/protected-path auditsThe corrected range received independent Linus approval with no findings. It changes no production behavior, API, handler, persistence/filesystem behavior, test seam, manifest, or roadmap file. The next Delegate popup test-ownership slice is excluded and has not started. Live ACP/backend and interactive terminal smoke were unavailable and are not claimed.