Skip to content

test: strengthen new session input contracts - #103

Merged
zatevakhin merged 2 commits into
refactor/componentsfrom
refactor/phase10-new-session-tests
Aug 30, 2026
Merged

test: strengthen new session input contracts#103
zatevakhin merged 2 commits into
refactor/componentsfrom
refactor/phase10-new-session-tests

Conversation

@zatevakhin

Copy link
Copy Markdown
Collaborator

Scope

  • Includes 69d621f0f64bf83c1f19513e41bc7a34fe0ba042 (test: strengthen new session input contracts) and fixture correction 73fd73f8f225935d9e7f6a890b0f7ae56450aca3 (test: make new session fixture collision-safe).
  • Changes only test bodies in src/features/sessions/input/new_session.rs, src/runtime/mod.rs, and src/handlers.rs (+356/-48).
  • Adds three tests overall, moving the complete suite from 1,170 to 1,173 tests.

Contracts

  • Keeps four owner-local tests covering all six NewSessionInputResult variants: Edited, MovedCompletion, AcceptCompletion, Submit, Cancel, and NotHandled.
  • Keeps root adapter/orchestration coverage for completion refresh, movement and unsupported-key no-ops, cancellation, connected/disconnected submission, launch-CWD and path normalization, profile propagation, completion acceptance, and global routing.
  • Corrects the test fixture to use exclusive create_dir, retry only AlreadyExists, and clean up only a directory it successfully created. This resolves the initial independent fixture-collision ownership finding in a separate commit.

Validation

  • cargo fmt --all -- --check
  • cargo check --all-targets --all-features
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --all-targets --all-features
  • All-feature debug and release suites twice each: 1,173 passed per run
  • Default suite: 1,173 passed
  • Focused owner 4, runtime popup 32 twice, handlers 49, application 62, and runtime 200
  • Filesystem-backed Edited test: five consecutive passes
  • git diff --check and exact scope/protected-path audits

The corrected range received independent Linus approval with no findings. It changes no production behavior, API, handler, persistence/filesystem behavior, test seam, manifest, or roadmap file. The next Delegate popup test-ownership slice is excluded and has not started. Live ACP/backend and interactive terminal smoke were unavailable and are not claimed.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d6727dd-a9c4-4502-881a-ef4437e0b255

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@zatevakhin
zatevakhin merged commit 568c2f4 into refactor/components Aug 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant