fix: block insert shortcuts during element placement - #56
Open
wuhaodesq-star wants to merge 1 commit into
Open
Conversation
Prevent addElement via keyboard or menu while placing a component or editing properties, so components cannot be created without entering required data. Fixes qucat#53 Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addElementactions (keyboard shortcuts and menu) while a component is being placed or the property panel is openProblem
Fixes #53 — pressing an insert shortcut (e.g.
R,C) while placing a new component could create additional elements on the canvas without opening the property dialog.Test plan
tests/gui/GUIAdapter.test.js— 2 new regression tests for Bug: If user adds a component with keystroke when placing a new component being created a component is allowed to be created without entering some data. #53Rto start placing a resistor, pressR/Cagain before clicking to place → no extra elementEscapestill cancels placement; Ctrl+Arrow still rotates during placement