Skip to content

Bump glob to 13 in vscode and lsp to resolve Snyk advisories#1019

Merged
cscheid merged 2 commits into
mainfrom
bump/some-security-updates-for-snyk-reporting
Jun 22, 2026
Merged

Bump glob to 13 in vscode and lsp to resolve Snyk advisories#1019
cscheid merged 2 commits into
mainfrom
bump/some-security-updates-for-snyk-reporting

Conversation

@juliasilge

Copy link
Copy Markdown
Collaborator

This PR bumps glob to ^13.0.6 in both the VS Code extension (apps/vscode) and the LSP (apps/lsp) to clear a set of Snyk-reported security advisories, plus the regenerated yarn.lock.

Previously apps/vscode used glob@^11.0.3 and apps/lsp used glob@^10.2.5. Both fell in the affected ranges for the glob CLI command injection advisory, and both dragged in vulnerable transitive minimatch and brace-expansion versions.

Advisories resolved

Moving to glob@13 cascades to clean transitive dependencies ([email protected], [email protected]) in both apps. The scoped @isaacs/brace-expansion package from the original advisory is no longer in either app's tree.

Notes

  • The glob command injection is CLI-only; the advisory states the library API is unaffected. Both apps use only the library API (glob() / glob.sync()), so there was no real exploit path here. The bump is to satisfy the version-based scanner.
  • Both glob call sites use the stable API that is unchanged across these major versions, so no code changes were needed.

Verification

  • yarn build-vscode passes (exit 0)
  • LSP build passes (exit 0)
  • yarn install --frozen-lockfile is consistent
  • No glob@10/11, [email protected], or @isaacs/brace-expansion remain in either app's runtime dependency tree

Out of scope

  • [email protected] and [email protected] still appear under dev/test tooling only (mocha, @vscode/test-cli); these are not shipped in either app and can be addressed separately.
  • packages/ojs/quarto-ojs-runtime is a standalone, separately published package and is not a dependency of the VS Code extension, so its advisories do not affect the extension.

@posit-snyk-bot

posit-snyk-bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@juliasilge

Copy link
Copy Markdown
Collaborator Author

What I plan to do is to get this merged, rescan in Snyk, and if everything looks as I expect, do a release of the Quarto extension.

@juliasilge juliasilge requested a review from cscheid June 22, 2026 18:29
@cscheid

cscheid commented Jun 22, 2026

Copy link
Copy Markdown
Member

lgtm! I'm going to merge it.

@cscheid cscheid merged commit a58e2e6 into main Jun 22, 2026
5 checks passed
@juliasilge juliasilge deleted the bump/some-security-updates-for-snyk-reporting branch June 22, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants