Bump glob to 13 in vscode and lsp to resolve Snyk advisories#1019
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
What I plan to do is to get this merged, rescan in Snyk, and if everything looks as I expect, do a release of the Quarto extension. |
Member
|
lgtm! I'm going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps
globto^13.0.6in both the VS Code extension (apps/vscode) and the LSP (apps/lsp) to clear a set of Snyk-reported security advisories, plus the regeneratedyarn.lock.Previously
apps/vscodeusedglob@^11.0.3andapps/lspusedglob@^10.2.5. Both fell in the affected ranges for the glob CLI command injection advisory, and both dragged in vulnerable transitiveminimatchandbrace-expansionversions.Advisories resolved
-c/--cmdoption. Affects glob10.2.0to10.4.xand11.0.0to11.0.x.@isaacs/brace-expansionbelow5.0.1, pulled in transitively via[email protected].minimatchReDoS advisories (GHSA-23c5-xmqv-rm74, GHSA-3ppc-4f35-3m26, GHSA-7r86-cg39-jmmj) that affected the older minimatch versions in these trees.Moving to
glob@13cascades to clean transitive dependencies ([email protected],[email protected]) in both apps. The scoped@isaacs/brace-expansionpackage from the original advisory is no longer in either app's tree.Notes
glob()/glob.sync()), so there was no real exploit path here. The bump is to satisfy the version-based scanner.Verification
yarn build-vscodepasses (exit 0)yarn install --frozen-lockfileis consistentglob@10/11,[email protected], or@isaacs/brace-expansionremain in either app's runtime dependency treeOut of scope
[email protected]and[email protected]still appear under dev/test tooling only (mocha,@vscode/test-cli); these are not shipped in either app and can be addressed separately.packages/ojs/quarto-ojs-runtimeis a standalone, separately published package and is not a dependency of the VS Code extension, so its advisories do not affect the extension.