Skip to content

fix(quarto-core): normalize CRLF in bootstrap-icons test assertion #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cscheid merged 1 commit into from
Jul 9, 2026
+7 −1
Merged

fix(quarto-core): normalize CRLF in bootstrap-icons test assertion #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/quarto-core/src/transforms/website_bootstrap_icons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,13 @@ mod tests {
assert_eq!(css.scope, ArtifactScope::Project);
assert_eq!(css.path.as_deref(), Some(Path::new(CSS_REL_PATH)));
assert_eq!(css.content_type, "text/css");
assert!(css.content.starts_with(b"/*!\n * Bootstrap Icons"));
// Line endings are normalized before the check: this served asset carries
// no SourceInfo/byte-offset and is never compared byte-for-byte with
// anything, so a Windows checkout (`core.autocrlf` rewriting the
// committed-LF vendored file to CRLF) must not false-positive on EOL.
let head_len = css.content.len().min(64);
let head = String::from_utf8_lossy(&css.content[..head_len]).replace("\r\n", "\n");
assert!(head.starts_with("/*!\n * Bootstrap Icons"));

let woff = store
.get("font:bootstrap-icons:bootstrap-icons.woff")
Expand Down
Loading