[CI] Add nightly ELD code coverage workflow with regression detection#1484
Open
Parth (parth-07) wants to merge 1 commit into
Open
[CI] Add nightly ELD code coverage workflow with regression detection#1484Parth (parth-07) wants to merge 1 commit into
Parth (parth-07) wants to merge 1 commit into
Conversation
Shankar Easwaran (quic-seaswara)
requested changes
Jul 16, 2026
| --show-branches=count \ | ||
| --show-expansions \ | ||
| --show-instantiations \ | ||
| --ignore-filename-regex='llvm-project/llvm/(include|lib|utils|unittests|examples|docs|cmake|test|benchmarks|projects|runtimes)/|llvm-project/llvm/tools/[^e]|llvm-project/llvm/tools/e[^l]|llvm-project/llvm/tools/el[^d]|llvm-project/(clang|clang-tools-extra)/|third-party/|/obj/tools/[^e]|/obj/tools/e[^l]|/obj/tools/el[^d]|/obj/(include|lib|bin)/|llvm-project/llvm/tools/eld/test/|llvm-project/llvm/tools/eld/Plugins/HelloWorldPlugin/' \ |
Contributor
There was a problem hiding this comment.
why ignore filename ? These projects are never built with coverage right ?
| COV_SUMMARY=$($SDLLVM_BIN/llvm-cov report \ | ||
| --instr-profile=eld.profdata \ | ||
| --object lib/libLW.so \ | ||
| --ignore-filename-regex='llvm-project/llvm/(include|lib|utils|unittests|examples|docs|cmake|test|benchmarks|projects|runtimes)/|llvm-project/llvm/tools/[^e]|llvm-project/llvm/tools/e[^l]|llvm-project/llvm/tools/el[^d]|llvm-project/(clang|clang-tools-extra)/|third-party/|/obj/tools/[^e]|/obj/tools/e[^l]|/obj/tools/el[^d]|/obj/(include|lib|bin)/|llvm-project/llvm/tools/eld/test/|llvm-project/llvm/tools/eld/Plugins/HelloWorldPlugin/') |
Contributor
There was a problem hiding this comment.
can this filename regex be checked in to the eld repo ?
| echo "FUNC_COV=$FUNC_COV" >> "$GITHUB_ENV" | ||
| echo "REGION_COV=$REGION_COV" >> "$GITHUB_ENV" | ||
| echo "BRANCH_COV=$BRANCH_COV" >> "$GITHUB_ENV" | ||
|
|
Contributor
There was a problem hiding this comment.
Do we need this ?
| ../llvm-project/llvm \ | ||
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON \ | ||
| -DLLVM_ENABLE_PROJECTS="llvm;clang;clang-tools-extra" \ |
Contributor
There was a problem hiding this comment.
why clang and clang-tools-extra ?
| jobs: | ||
| coverage: | ||
| if: github.repository == 'qualcomm/eld' | ||
| runs-on: self-hosted |
Contributor
There was a problem hiding this comment.
We can use the free runners
|
|
||
| - name: Build | ||
| working-directory: obj | ||
| run: ninja |
Contributor
There was a problem hiding this comment.
ninja ld.eld
Contributor
There was a problem hiding this comment.
Use clang from the toolchain itself
|
|
||
| - name: Merge profile data | ||
| working-directory: obj | ||
| run: $SDLLVM_BIN/llvm-profdata merge -sparse eld-*.profraw -o eld.profdata |
Contributor
There was a problem hiding this comment.
why SDLLVM_BIN ? :)
| git commit -m "Update ELD coverage report ($(date -u '+%Y-%m-%d'))" | ||
| git push -f origin HEAD:refs/heads/code-coverage-reports | ||
|
|
||
| - name: Prune ccache after build |
Contributor
There was a problem hiding this comment.
You need save/restore ccache action.
Parth (parth-07)
force-pushed
the
code-coverage-workflow
branch
from
July 17, 2026 09:36
7e09cbc to
15b56b4
Compare
Add nightly-eld-code-coverage.yml which runs daily after the nightly build. The workflow: - Builds LLVM+ELD with source-based coverage instrumentation (ELD_COVERAGE=ON) - Runs check-eld under LLVM_PROFILE_FILE to collect per-process .profraw files - Merges profiles and generates an HTML report with llvm-profdata / llvm-cov - Compares Line/Function/Region/Branch coverage against a baseline stored on the code-coverage-reports branch and fails if any metric regresses - Records the baseline on the first run when none exists - Publishes the HTML report and updated baseline to the code-coverage-reports branch Also updates CMakeLists.txt: ELD_COVERAGE now sets the llvm-cov source-based instrumentation flags (-fprofile-instr-generate -fcoverage-mapping). Signed-off-by: bsaharsh <[email protected]>
Parth (parth-07)
force-pushed
the
code-coverage-workflow
branch
from
July 22, 2026 11:24
15b56b4 to
96e0a2c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| echo "COV_IGNORE_REGEX=$COV_IGNORE_REGEX" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Restore ccache | ||
| uses: actions/cache@v4 |
|
|
||
| - name: Save ccache | ||
| if: always() | ||
| uses: actions/cache/save@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nightly-eld-code-coverage.yml which runs daily after the nightly build. The workflow:
Also updates CMakeLists.txt: ELD_COVERAGE option now sets llvm-cov source-based instrumentation flags (-fprofile-instr-generate -fcoverage-mapping) instead of gcov (--coverage).