Add support for /dev/null input file#1471
Open
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Open
Add support for /dev/null input file#1471Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Steven Ramirez Rosa (Steven6798)
requested review from
Parth (parth-07),
quic-areg and
Shakti Suman (quic-shaksuma)
July 14, 2026 17:24
Steven Ramirez Rosa (Steven6798)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
July 14, 2026 17:24
Shankar Easwaran (quic-seaswara)
requested changes
Jul 14, 2026
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1464
branch
from
July 14, 2026 18:25
e5af465 to
7d684e5
Compare
Steven Ramirez Rosa (Steven6798)
requested a review
from Shankar Easwaran (quic-seaswara)
July 14, 2026 18:38
Fix: qualcomm#1464 Signed-off-by: Steven Ramirez Rosa <[email protected]>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1464
branch
from
July 14, 2026 20:40
7d684e5 to
9cb3787
Compare
Steven Ramirez Rosa (Steven6798)
changed the title
quic-areg
approved these changes
Jul 22, 2026
Shankar Easwaran (quic-seaswara)
requested changes
Jul 22, 2026
|
|
||
| bool InputFileAction::activate(InputBuilder &PBuilder) { | ||
| // Skip null file. | ||
| if (eld::utility::isNullDevice(Name)) |
Contributor
There was a problem hiding this comment.
For a linker, is there any difference in /dev/null and an empty file, assuming that /dev/null is provided by the runtime/OS?
Contributor
Author
There was a problem hiding this comment.
Yes. both GNU ld and lld behave different in both cases.
$ ld.lld
ld.lld: error: no input files
$ ld.lld /dev/null
ld.lld: error: target emulation unknown: -m or at least one .o file required
$ ld
ld: no input files
$ ld /dev/null
ld: warning: cannot find entry symbol _start; not setting start address
Steven Ramirez Rosa (Steven6798)
requested a review
from Shankar Easwaran (quic-seaswara)
July 23, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1464