[RISCV] Add tests for all relocs that ignore non-zero addends#1428
Merged
Jonathon Penix (jonathonpenix) merged 1 commit intoJul 22, 2026
Merged
Conversation
As far as I can tell these weren't tested elsewhere. Add tests similar to what was already done for PCREL_LO12_I. Also fixup a stale comment after the relocation handling was refactored recently. Signed-off-by: Jonathon Penix <[email protected]>
Jonathon Penix (jonathonpenix)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
July 8, 2026 20:28
quic-areg
approved these changes
Jul 8, 2026
Shankar Easwaran (quic-seaswara)
approved these changes
Jul 21, 2026
Shankar Easwaran (quic-seaswara)
requested changes
Jul 21, 2026
Shankar Easwaran (quic-seaswara)
left a comment
Shankar Easwaran (quic-seaswara)
left a comment
Contributor
There was a problem hiding this comment.
Update the developer docs accordingly
Contributor
Author
|
What sort of updates are you looking for? This is just adding tests/updating comments/renaming the diag--it should be NFC If you mean documenting addends or something, this info is already clearly marked in the psABI--I'm a bit hesitant to create a downstream copy of all that info that we have to maintain. |
Contributor
|
sorry I was trying to add to this PR. By mistake it landed on this PR. Ignore my comment for this PR. |
Shankar Easwaran (quic-seaswara)
approved these changes
Jul 22, 2026
Jonathon Penix (jonathonpenix)
merged commit Jul 22, 2026
c99defe
into
qualcomm:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell these weren't tested elsewhere. Add tests similar to what was already done for PCREL_LO12_I.
Also fixup a stale comment after the relocation handling was refactored recently.