Skip to content

FROMLIST: arm64: dts: qcom: lemans: enable EUD support#543

Open
akakum-qualcomm wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:lemans-eud
Open

FROMLIST: arm64: dts: qcom: lemans: enable EUD support#543
akakum-qualcomm wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:lemans-eud

Conversation

@akakum-qualcomm
Copy link
Copy Markdown

@akakum-qualcomm akakum-qualcomm commented May 6, 2026

Add the EUD controller node in lemans.dtsi and update the USB HS endpoint routing on lemans-evk to pass through EUD instead of linking the connector directly to usb_0_dwc3_hs.

Wire the OF graph endpoints between the connector, EUD and DWC3 HS controller to enable the EUD path on lemans EVK.

Link: https://lore.kernel.org/all/[email protected]/

CRs-Fixed: 4526711

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ◻️ ◻️ ◻️ ❌ Fail ◻️ ◻️ ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_SCAN ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPU_affinity ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Ethernet ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ⚠️ skip ◻️ ◻️
Freq_Scaling ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
GIC ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
IPA ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Interrupts ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
OpenCV ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
PCIe ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ◻️ ❌ Fail ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
RMNET ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
UFS_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
USBHost ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ◻️ ◻️
hotplug ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
irq ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
kaslr ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
pinctrl ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
qcom_hwrng ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
rngtest ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
shmbridge ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
smmu ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
watchdog ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ◻️ ◻️ ◻️ ❌ Fail ◻️ ◻️ ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_SCAN ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPU_affinity ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Ethernet ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ⚠️ skip ◻️ ◻️
Freq_Scaling ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
GIC ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
IPA ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Interrupts ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
OpenCV ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
PCIe ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ◻️ ❌ Fail ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
RMNET ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
UFS_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
USBHost ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ◻️ ◻️
hotplug ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
irq ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
kaslr ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
pinctrl ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
qcom_hwrng ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
rngtest ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
shmbridge ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
smmu ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
watchdog ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️

Copy link
Copy Markdown
Contributor

@sgaud-quic sgaud-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix :

No associated change tasks found for CR [4526711](https://orbit//CR/4526711) on any of the following entities: kernel.qli.2.0.

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ◻️ ◻️ ◻️ ❌ Fail ◻️ ◻️ ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_SCAN ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPU_affinity ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Ethernet ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ⚠️ skip ◻️ ◻️
Freq_Scaling ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
GIC ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
IPA ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Interrupts ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
OpenCV ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
PCIe ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ◻️ ❌ Fail ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
RMNET ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
UFS_Validation ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
USBHost ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ◻️ ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ◻️ ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ◻️ ◻️
hotplug ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
irq ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
kaslr ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
pinctrl ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
qcom_hwrng ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
rngtest ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
shmbridge ◻️ ◻️ ◻️ ✅ Pass ◻️ ❌ Fail ✅ Pass ❌ Fail ◻️ ◻️
smmu ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
watchdog ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️

@akakum-qualcomm
Copy link
Copy Markdown
Author

Please fix :

No associated change tasks found for CR [4526711](https://orbit//CR/4526711) on any of the following entities: kernel.qli.2.0.

Please ensure the CR has a change task associated with at least one of the entities for this branch.

Done.

@akakum-qualcomm akakum-qualcomm requested a review from sgaud-quic May 8, 2026 04:12
Copy link
Copy Markdown

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link: https://lore.kernel.org/all/[email protected]/

unable to locate this change in lore, please fix the link.

@akakum-qualcomm
Copy link
Copy Markdown
Author

Link: https://lore.kernel.org/all/[email protected]/

unable to locate this change in lore, please fix the link.

please check this
https://lore.kernel.org/all/[email protected]/

Copy link
Copy Markdown

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two DTS formatting issues need to be fixed before merging (see inline comments).

Comment thread arch/arm64/boot/dts/qcom/lemans.dtsi Outdated
#address-cells = <1>;
#size-cells = <0>;

port@0 {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port@0 is indented with 3 tabs but should be 4 tabs to match port@1.

Suggested change
port@0 {
port@0 {

Comment thread arch/arm64/boot/dts/qcom/lemans-evk.dts Outdated
Add the EUD controller node in lemans.dtsi and update the USB HS
endpoint routing on lemans-evk to pass through EUD instead of linking
the connector directly to usb_0_dwc3_hs.

Wire the OF graph endpoints between the connector, EUD and DWC3 HS
controller to enable the EUD path on lemans EVK.

Link: https://lore.kernel.org/all/[email protected]/

Signed-off-by: Akash Kumar <[email protected]>
@qcomlnxci qcomlnxci requested a review from a team May 20, 2026 05:39
@qlijarvis
Copy link
Copy Markdown

PR #543 — validate-patch

PR: #543

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/[email protected]/; valid FROMLIST: lore URL
  2. Lore link matches PR commits: N/A (network unavailable to fetch lore patch for interdiff); structural analysis of PR diff shows self-consistent, well-formed changes matching the stated commit message purpose; no anomalies detected
  3. Upstream patch status: ⏳ Decision Pending — posted 2026-05-12; FROMLIST: prefix indicates not yet merged at PR submission time; network unavailable to confirm current thread status
  4. PR present in qcom-next: Not checked — local kernel mirror absent and network blocked; verify manually with git log --oneline --grep="arm64: dts: qcom: lemans: enable EUD support" on qcom-next
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: FROMLIST: arm64: dts: qcom: lemans: enable EUD support — PR #543
Upstream commit: https://lore.kernel.org/all/[email protected]/
Verdict: ⚠️ PARTIAL


CoT Walkthrough

Step 1 — Lore link check:
PR changes arch/arm64/boot/dts/qcom/lemans-evk.dts and arch/arm64/boot/dts/qcom/lemans.dtsi. Lore link found: https://lore.kernel.org/all/[email protected]/. Prefix is FROMLIST: — lore link is required and present. ✅

Step 2 — Lore fetch:
Network access is blocked in this environment; b4 is not installed and curl cannot resolve lore.kernel.org. Lore patch could not be fetched. Diff comparison is performed by structural analysis of the PR patch content and message-id metadata.

Step 3 — Upstream status:
The message-id [email protected] was posted on 2026-05-12. The FROMLIST: prefix confirms the author considers it not yet merged. Network is unavailable to query thread replies or check for an applied tag. Community verdict: ⏳ Decision Pending — posted 2026-05-12, no network access to confirm acceptance; FROMLIST: prefix indicates not yet merged at PR submission time.

Step 4 — PR diff:
Two files changed, 4 hunks total:

  • lemans-evk.dts: 3 hunks — re-routes USB HS endpoint through EUD
  • lemans.dtsi: 1 hunk — adds eud@88e1000 node

Step 5 — Normalisation:
Lore patch unavailable for interdiff. Structural analysis performed directly on PR patch.

Step 6 — Commit message analysis:

  • Subject: FROMLIST: arm64: dts: qcom: lemans: enable EUD supportFROMLIST: prefix correctly prepended to the upstream subject.
  • Body: Describes adding EUD controller node and re-routing USB HS endpoint through EUD on lemans-evk. Rationale is clear and self-contained.
  • Fixes: tag: Not present — this is a feature addition (EUD enablement), not a bug fix. Absence is correct.
  • Authorship (FROMLIST: rules): From: Akash Kumar <[email protected]>. The lore message-id encodes the author as [email protected]. These are the same person (Akash Kumar at Qualcomm) using two different corporate email aliases (internal QTI vs. OSS/upstream). The PR Signed-off-by: uses only the internal address [email protected]; the lore OSS address [email protected] does not appear explicitly. Per FROMLIST: rules, the lore author's Signed-off-by: must be present — this is a ⚠️ WARNING.
  • Backport note: N/A — FROMLIST:, not a backport.
  • Co-developed-by: misuse: Not present — correct.

Step 7 — Diff content:
Cannot perform interdiff (lore unavailable). Structural review of the PR diff:

  • The 3 hunks in lemans-evk.dts form a coherent, self-consistent re-routing: connector HS endpoint → EUD con, EUD ep → DWC3 HS. The line-number shift in hunk 3 (-1127+1135, +8 lines) is exactly consistent with the 8 lines added in hunk 2. No anomalies.
  • The lemans.dtsi hunk adds a well-formed eud@88e1000 node with compatible = "qcom,sc7280-eud", "qcom,eud", two register ranges, one interrupt, and two OF-graph ports. The sc7280-eud specific compatible is the established fallback for sa8775p-family EUD (same IP block); qcom,eud is the generic. This is consistent with how other Qualcomm platforms use this driver.
  • No extra hunks, no missing hunks relative to the stated purpose.

Step 8 — File paths and symbols:
File paths match the standard kernel DTS layout. Symbols (eud_ep, eud_con, usb0_con_hs_ep, usb_0_dwc3_hs) are used consistently across all hunks. No renames or path discrepancies.

Step 9 — Dependency completeness:
The commit message mentions no Depends-on: or series prerequisites. The message-id suffix -1- confirms this is a single-patch series ([PATCH 1/1]). The EUD driver binding (qcom,sc7280-eud) must already exist in the tree for this DTS to be valid — this is a pre-existing binding, not introduced by this patch. No missing dependencies identified.

Step 10 — qcom-next presence:
Local kernel mirror at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel is absent and network is blocked. Cannot verify. ⏭️ Skipped.


Commit Message

Check Status Note
Subject matches upstream FROMLIST: prefix added; base subject identical to lore message-id subject
Body preserves rationale EUD node addition and USB HS re-routing described accurately
Fixes tag present/correct N/A — feature addition, no Fixes tag needed
Authorship preserved ⚠️ FROMLIST: rule: lore author email [email protected] not present in Signed-off-by:; only internal alias [email protected] appears
Backport note (if applicable) N/A Not a backport
Co-developed-by used correctly Not present — correct

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-evk.dts 3 hunks; coherent EUD endpoint re-routing; line-number shifts consistent with added lines
arch/arm64/boot/dts/qcom/lemans.dtsi 1 hunk; well-formed eud@88e1000 node with correct compatible, reg, interrupt, and OF-graph ports

Issues

  • ⚠️ Authorship email mismatch in Signed-off-by: — The lore patch was posted from [email protected] (the upstream OSS address). The PR commit carries only Signed-off-by: Akash Kumar <[email protected]> (internal QTI alias). For FROMLIST: commits the lore author's Signed-off-by: must be present. Since both addresses belong to the same person, the fix is to add a second Signed-off-by: line with the OSS address, or use the OSS address as the primary:
    Signed-off-by: Akash Kumar <[email protected]>
    

Verdict

Patch is structurally sound and the diff faithfully implements the stated purpose; request the author add Signed-off-by: Akash Kumar <[email protected]> (the lore OSS email) to satisfy FROMLIST: authorship requirements before merging.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/[email protected]/; valid FROMLIST: lore URL
  2. Lore link matches PR commits: N/A (network unavailable to fetch lore patch for interdiff); structural analysis of PR diff shows self-consistent, well-formed changes matching the stated commit message purpose; no anomalies detected
  3. Upstream patch status: ⏳ Decision Pending — posted 2026-05-12; FROMLIST: prefix indicates not yet merged at PR submission time; network unavailable to confirm current thread status
  4. PR present in qcom-next: Not checked — local kernel mirror absent and network blocked; verify manually with git log --oneline --grep="arm64: dts: qcom: lemans: enable EUD support" on qcom-next

@qlijarvis
Copy link
Copy Markdown

PR #543 — checker-log-analyzer

PR: #543
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26143700105

Checker Result Summary
Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed (graph_port warnings are pre-existing, subtracted out)
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance Content mismatch + author email mismatch
tag-check Subject starts with FROMLIST:
qcom-next-check N/A Target is qcom-6.18.y, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: lemans: enable EUD support (#543)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26143700105
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed (graph_port warnings are pre-existing, subtracted out)
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance Content mismatch + author email mismatch
tag-check Subject starts with FROMLIST:
qcom-next-check N/A Target is qcom-6.18.y, not qcom-next

❌ check-patch-compliance

Root cause: The commit's diff differs from the upstream lore patch it links to, and the commit author email ([email protected]) does not match the original author email in the mbox ([email protected]).

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: lemans: enable EUD support
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Akash Kumar <[email protected]>
  Commit author : Akash Kumar <[email protected]>

Fix — two independent issues to resolve:

Issue 1 — Author email mismatch:
The commit was authored with the internal QTI email ([email protected]) but the upstream mbox uses the OSS email ([email protected]). Fix by amending the author:

git rebase -i <base_sha>   # mark the commit as 'edit'
git commit --amend --author="Akash Kumar <[email protected]>"
git rebase --continue

Issue 2 — Content mismatch:
The diff in the PR does not exactly match the patch at the linked lore URL. Fetch the upstream patch and compare:

b4 am --single-message -C -l -3 \
  https://lore.kernel.org/all/[email protected]/ \
  -o /tmp/upstream-patch

# Compare +/- lines between PR commit and upstream mbox
diff \
  <(git format-patch -1 04da15e1c79b7c4b1d19b006b4ce2e8828852f0e --stdout \
      | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
  <(awk '/^diff/,/^--$/' /tmp/upstream-patch/*.mbx \
      | grep -E '^[+-][^+-]')

Classify the delta:

  • If it is a context-only shift (line numbers differ but content is identical) → not a real mismatch; the checker may be overly strict. Re-trigger CI after fixing the author.
  • If there are extra or missing hunks → align the PR diff to the upstream patch, or document the intentional adaptation in the commit message.

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src <path/to/kernel> \
  --base 0136c1ed9c23851783df4ad39ad3556497cc3c2a \
  --head <head_sha>

Verdict

1 blocker to fix before merge: resolve the author email mismatch ([email protected][email protected]) and investigate/align the content difference flagged by check-patch-compliance. All other checkers pass or are not applicable to this DTS-only patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants