Fix coverage injection on new GitHub diff UI#83
Open
davehenton wants to merge 1 commit into
Open
Conversation
Two bugs prevented coverage gutters from rendering on PR diffs: 1. GitHub injects multiple U+200E (LRM) characters in file-path link text. The path normalizer used String#replace, which only strips the first occurrence, so a trailing LRM survived and the API request 404'd on path mismatch. Switched to replaceAll. 2. tryInjectDiffCommitUI marked the root container as processed on first run, even when no gutter cells had rendered yet (the new React-based diff renders file-index links before grid cells). The MutationObserver guard then short-circuited every retry. Removed the root-level guard and moved the per-link processed flag to fire only after a successful injection, so the observer keeps retrying as cells appear. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs prevented coverage gutters from rendering on PR diffs:
GitHub injects multiple U+200E (LRM) characters in file-path link text. The path normalizer used String#replace, which only strips the first occurrence, so a trailing LRM survived and the API request 404'd on path mismatch. Switched to replaceAll.
tryInjectDiffCommitUI marked the root container as processed on first run, even when no gutter cells had rendered yet (the new React-based diff renders file-index links before grid cells). The MutationObserver guard then short-circuited every retry. Removed the root-level guard and moved the per-link processed flag to fire only after a successful injection, so the observer keeps retrying as cells appear.