Fix as number of images instead of eposide in rollouts#10
Open
Xciyang wants to merge 1 commit into
Open
Conversation
The directory rollouts/minedojo_task/image_from_agent/timestamp is usually saved as episode_x/image/step.png, while os.listdir retrieves the folder under episode_x. The image_num is not the number of images but the episode. By default, the rollout_image_num in config.yaml is set to 2000, which is consistent with the number of images used to train UNET in the paper. Therefore, pathlib should be used instead of os.listdir to recursively retrieve images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory
rollouts/minedojo_task/image_from_agent/timestampis usually saved asepisode_x/image/step.png, whileos.listdirretrieves the folder underepisode_x. Theimage_numis not the number of images but the episode.By default, the
rollout_image_numinconfig.yamlis set to 2000, which is consistent with the number of images used to train U-Net in the paper. Therefore,pathlibshould be used instead ofos.listdirto recursively retrieve images.