Skip to content

Disable scaling in MapExport when no frame is given - #662

Open
BenediktSeidlSWM wants to merge 1 commit into
qgis:masterfrom
BenediktSeidlSWM:mapexport
Open

Disable scaling in MapExport when no frame is given#662
BenediktSeidlSWM wants to merge 1 commit into
qgis:masterfrom
BenediktSeidlSWM:mapexport

Conversation

@BenediktSeidlSWM

Copy link
Copy Markdown
Contributor

The missing parameter leads to weird glitches in the MapExport plugin, since 8c6a0c0

@manisandro

manisandro commented Jun 10, 2026

Copy link
Copy Markdown
Member

What weird glitches? As far as I can see, it works correctly and it is useful to be able to resize an existing selection?

@BenediktSeidlSWM

Copy link
Copy Markdown
Contributor Author

The glitch we noticed is hard to reproduce, but if the user selects a box and then quickly tries to select another box after releasing the mouse, the map moves instead of drawing another rectangle. We were able to avoid that issue by disabling the resizing. Also I think it is confusing that the user cannot move the extent nor change the aspect ratio after selecting a box but only scale it around the intial center. In my opinion, it is easier to just select a new rectangle.

@BenediktSeidlSWM

Copy link
Copy Markdown
Contributor Author

We could also make this an option by defining allowScaling={this.props.allowedScales !== false} like it is defined a few lines above.

@manisandro

Copy link
Copy Markdown
Member

Uhm so far haven't been able to reproduce the glitch. Regarding allowScaling={this.props.allowedScales !== false}, in non-fixed-page-mode, the size of the selection is actually not related to the map scale, changing the map scale will just result in a larger/smaller image being requested for the selected area.

In my view resizing the rectangle can actually be useful, though more useful if were actually a free resize, not aspect-ratio preserving scaling.

@manisandro
manisandro force-pushed the master branch 6 times, most recently from 15358a2 to 96e2e46 Compare July 10, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants