Sync 1.19 client with latest dev protobuf - #290
Merged
Conversation
Follow-up to #288. Upstream `dev` changed two things after that sync: * `StrictModeConfig.max_disk_usage_percent` (field 22) is gone — reserved, superseded by the global quota config. `max_resident_memory_percent` is now marked `[deprecated = true]` for the same reason, with removal planned for 1.21. The builder setter for the removed field is dropped (never released — latest tag is v1.18.0, so this breaks no published version), and the remaining setter gets a doc note instead of a `#[deprecated]` attribute, matching the convention from #288. * The `Search`/`SearchBatch`/`SearchGroups`, `Recommend`/`RecommendBatch`/ `RecommendGroups` and `Discover`/`DiscoverBatch` RPCs are marked deprecated in favour of the Query API, so the generated tonic client methods now carry `#[deprecated]`. The `Qdrant::search_points`/`recommend`/`discover` wrappers keep working warning-free (`#[allow(deprecated)]` internally) and point at their Query API replacements via doc notes, so a 1.18 -> 1.20 bump stays source-compatible for downstream crates building with `-D warnings`. Verified with `cargo clippy --workspace --all-targets --all-features -D warnings` (clean) and `tests/integration-tests.sh` against `qdrant/qdrant:dev` (30 + 1 + 1 + 79 + 111 tests, all passing). Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
timvisee
pushed a commit
that referenced
this pull request
Aug 4, 2026
Follow-up to #288. Upstream `dev` changed two things after that sync: * `StrictModeConfig.max_disk_usage_percent` (field 22) is gone — reserved, superseded by the global quota config. `max_resident_memory_percent` is now marked `[deprecated = true]` for the same reason, with removal planned for 1.21. The builder setter for the removed field is dropped (never released — latest tag is v1.18.0, so this breaks no published version), and the remaining setter gets a doc note instead of a `#[deprecated]` attribute, matching the convention from #288. * The `Search`/`SearchBatch`/`SearchGroups`, `Recommend`/`RecommendBatch`/ `RecommendGroups` and `Discover`/`DiscoverBatch` RPCs are marked deprecated in favour of the Query API, so the generated tonic client methods now carry `#[deprecated]`. The `Qdrant::search_points`/`recommend`/`discover` wrappers keep working warning-free (`#[allow(deprecated)]` internally) and point at their Query API replacements via doc notes, so a 1.18 -> 1.20 bump stays source-compatible for downstream crates building with `-D warnings`. Verified with `cargo clippy --workspace --all-targets --all-features -D warnings` (clean) and `tests/integration-tests.sh` against `qdrant/qdrant:dev` (30 + 1 + 1 + 79 + 111 tests, all passing). Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #288. Upstream
devchanged the API again after that sync — re-ran./tools/sync_proto.shand adjusted the hand-written surface.Protobuf changes picked up
StrictModeConfig(collections.proto)max_disk_usage_percent(field 22) is removed and reserved — superseded by the global quota config.max_resident_memory_percent(field 21) is now[deprecated = true]for the same reason (memory is node-wide), removal planned for 1.21.Points service (
points_service.proto)Search,SearchBatch,SearchGroups,Recommend,RecommendBatch,RecommendGroups,DiscoverandDiscoverBatchare markedoption deprecated = truein favour of the Query API, so the generated tonic client methods now carry#[deprecated].Client changes
StrictModeConfigBuilder::max_disk_usage_percentis dropped. The field never shipped — latest tag isv1.18.0and it was only added in the unreleased Update rust client for 1.19 #288 — so no published version breaks.StrictModeConfigBuilder::max_resident_memory_percentkeeps working and gains a doc note about the deprecation rather than a#[deprecated]attribute, matching the convention established in Update rust client for 1.19 #288 (an attribute would be a hard error for downstream crates building with-D warnings).build_innergets#[allow(deprecated)], same as the other builders touching deprecated fields.Qdrant::search_points/recommend/discoverwrappers get#[allow(deprecated)]around the now-deprecated tonic calls, plus doc notes pointing at their Query API replacements. They stay callable warning-free, so a 1.18 -> 1.20 bump remains source-compatible.tests/snippet_tests/test_update_collection_memory.rsno longer sets the removed field.Verification
cargo fmt --all -- --check— cleancargo clippy --workspace --all-targets --all-features -- -D warnings— cleantests/integration-tests.shagainstqdrant/qdrant:dev— 30 + 1 + 1 + 79 + 111 tests, all passing🤖 Generated with Claude Code