Skip to content

Fixed the bug in '/api/gas_average_measurement/'#122

Open
Aparna-Sakshi wants to merge 1 commit into
qAIRa:masterfrom
Aparna-Sakshi:bug_gas_avg_measurement
Open

Fixed the bug in '/api/gas_average_measurement/'#122
Aparna-Sakshi wants to merge 1 commit into
qAIRa:masterfrom
Aparna-Sakshi:bug_gas_avg_measurement

Conversation

@Aparna-Sakshi

Copy link
Copy Markdown
Contributor

Summary

In this PR:

  1. Missing timestamp issue is fixed by generating a series of timestamps in the past 24 hours and left joining it with the actual 'values' table.
  2. If the sensor value is null, it is replaced with "" (i.e) empty string.
  3. Redundant code in getFormatData is also removed.

Related Issue:

Files (Functions) changed

  1. get_data_helper.py (queryDBGasAverageMeasurement)
  2. util_helper.py (getFormatData)

@Aparna-Sakshi

Copy link
Copy Markdown
Contributor Author

@GersonMontesinos could you please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant