[release/2.11] Pass extension sources as str, not pathlib.Path#4210
[release/2.11] Pass extension sources as str, not pathlib.Path#4210ethanwee1 wants to merge 1 commit into
Conversation
get_ext_modules() built the CppExtension/CUDAExtension `sources` lists
from `_CSRC_DIR / "..."`, i.e. pathlib.Path objects. Newer
setuptools/distutils enforces that `sources` is a list of str and now
raises:
AssertionError: 'sources' must be a list of strings
which breaks `setup.py bdist_wheel`. Wrap each source path in str() so
the list contains plain strings. include_dirs are left as-is (distutils
does not assert on them).
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4210
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @ethanwee1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Closing — for ROCm release/2.11 the fix will land in ROCm/audio (see ROCm#19) and the wheel pipeline's related_commits will point at ROCm/audio, not pytorch/audio. |
Why
get_ext_modules()builds the extensionsourceslists from_CSRC_DIR / "...", i.e.pathlib.Pathobjects. Older setuptools acceptedos.PathLike, but newer setuptools/distutils now asserts thatsourcesis a list ofstr:This breaks
python setup.py bdist_wheelwith a sufficiently new setuptools.Fix
Wrap each source path in
str()in the threeextension(sources=...)lists.include_dirsare left unchanged (distutils does not assert on them).